[PATCH v3 1/1] media: dt-bindings: convert ovti,ov2659.txt to yaml format

[PATCH v3 1/1] media: dt-bindings: convert ovti,ov2659.txt to yaml format

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Convert the OmniVision OV2659 camera sensor binding from plain text to
YAML schema format.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v3
- update subject.

change in v2
- drop rob's review by because use new file
- use new file ovti,2659 according to sakari's feedback
- v1 (2025) https://lore.kernel.org/imx/aPdHqCWNdmVkch7S@valkosipuli.retiisi.eu/
---
 .../bindings/media/i2c/ovti,ov2659.txt        | 47 ---------
 .../bindings/media/i2c/ovti,ov2659.yaml       | 95 +++++++++++++++++++
 2 files changed, 95 insertions(+), 47 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2659.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt
deleted file mode 100644
index 92989a619f292..0000000000000
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt
+++ /dev/null
@@ -1,47 +0,0 @@
-* OV2659 1/5-Inch 2Mp SOC Camera
-
-The Omnivision OV2659 is a 1/5-inch SOC camera, with an active array size of
-1632H x 1212V. It is programmable through a SCCB. The OV2659 sensor supports
-multiple resolutions output, such as UXGA, SVGA, 720p. It also can support
-YUV422, RGB565/555 or raw RGB output formats.
-
-Required Properties:
-- compatible: Must be "ovti,ov2659"
-- reg: I2C slave address
-- clocks: reference to the xvclk input clock.
-- clock-names: should be "xvclk".
-- link-frequencies: target pixel clock frequency.
-
-Optional Properties:
-- powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any.
-  Active high with internal pull down resistor.
-- reset-gpios: reference to the GPIO connected to the resetb pin, if any.
-  Active low with internal pull up resistor.
-
-For further reading on port node refer to
-Documentation/devicetree/bindings/media/video-interfaces.txt.
-
-Example:
-
-	i2c0@1c22000 {
-		...
-		...
-		 ov2659@30 {
-			compatible = "ovti,ov2659";
-			reg = <0x30>;
-
-			clocks = <&clk_ov2659 0>;
-			clock-names = "xvclk";
-
-			powerdown-gpios = <&gpio6 14 GPIO_ACTIVE_HIGH>;
-			reset-gpios = <&gpio6 15 GPIO_ACTIVE_LOW>;
-
-			port {
-				ov2659_0: endpoint {
-					remote-endpoint = <&vpfe_ep>;
-					link-frequencies = /bits/ 64 <70000000>;
-				};
-			};
-		};
-		...
-	};
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.yaml
new file mode 100644
index 0000000000000..926e5cd966b8d
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.yaml
@@ -0,0 +1,95 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ovti,ov2659.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: OmniVision OV2659 1/5-Inch 2Mp SOC Camera
+
+maintainers:
+  - Frank Li <Frank.Li@kernel.org>
+
+description:
+  The Omnivision OV2659 is a 1/5-inch SOC camera, with an active array size of
+  1632H x 1212V. It is programmable through a SCCB. The OV2659 sensor supports
+  multiple resolutions output, such as UXGA, SVGA, 720p. It also can support
+  YUV422, RGB565/555 or raw RGB output formats.
+
+properties:
+  compatible:
+    const: ovti,ov2659
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: xvclk
+
+  powerdown-gpios:
+    description:
+      Reference to the GPIO connected to the pwdn pin, if any.
+      Active high with internal pull down resistor.
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Reference to the GPIO connected to the resetb pin, if any.
+      Active low with internal pull up resistor.
+    maxItems: 1
+
+  port:
+    $ref: /schemas/graph.yaml#/$defs/port-base
+    unevaluatedProperties: false
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          link-frequencies:
+            description: Target pixel clock frequency.
+            maxItems: 1
+
+        required:
+          - link-frequencies
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@30 {
+            compatible = "ovti,ov2659";
+            reg = <0x30>;
+
+            clocks = <&clk_ov2659 0>;
+            clock-names = "xvclk";
+
+            powerdown-gpios = <&gpio6 14 GPIO_ACTIVE_HIGH>;
+            reset-gpios = <&gpio6 15 GPIO_ACTIVE_LOW>;
+
+            port {
+                endpoint {
+                    remote-endpoint = <&vpfe_ep>;
+                    link-frequencies = /bits/ 64 <70000000>;
+                };
+            };
+        };
+    };
-- 
2.43.0

Re: [PATCH v3 1/1] media: dt-bindings: convert ovti,ov2659.txt to yaml format

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Dangling reference in MAINTAINERS file due to renamed binding.
--

commit 86f22844bc16fc2237e1a2e032a70e273a8be8f0
Author: Frank Li <Frank.Li@nxp.com>

media: dt-bindings: convert ovti,ov2659.txt to yaml format
    
Convert the OmniVision OV2659 camera sensor binding from plain text to
YAML schema format.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt
> deleted file mode 100644
> index 92989a619f292..0000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt
> +++ /dev/null

[Severity: Low]
Does this file deletion need to be accompanied by an update to the MAINTAINERS
file? The OV2659 OMNIVISION SENSOR DRIVER section currently references this
deleted .txt file, which will result in tools like get_maintainer.pl parsing a
dangling reference and potentially missing routing updates for the new YAML
file:

MAINTAINERS:
OV2659 OMNIVISION SENSOR DRIVER
...
F:	Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831161121.4048134-1-Frank.Li@oss.nxp.com?part=1