[PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[Marek Vasut]

The TMP113 temperature sensor part is register compatible with TMP102,
document it using a fallback compatible. Unlike TMP102 and TMP110, the
TMP113 does have additional unique ID registers, it is up to the driver
to handle those.

Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
V2: Rebase on current next and resend, resolve a conflict with commit
    d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
    Note that the TMP102,110,113 are backward compatible, therefore the
    valid compatible strings are:
    - "ti,tmp110", "ti,tmp102"
    - "ti,tmp113", "ti,tmp102"
    - "ti,tmp102"
    The TMP103 is not backward compatible, it only shares bindings now,
    therefore the only valid compatible string for the TMP103 should be:
    - "ti,tmp103"
    And that is all, no other compatible strings are acceptable here.
---
 .../devicetree/bindings/hwmon/ti,tmp102.yaml          | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
index 55d9f106465d7..c0b747a9ce0de 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
@@ -4,7 +4,7 @@
 $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: TMP102/TMP103/TMP110 temperature sensor
+title: TMP102/TMP103/TMP110/TMP113 temperature sensor
 
 maintainers:
   - Krzysztof Kozlowski <krzk@kernel.org>
@@ -13,11 +13,12 @@ properties:
   compatible:
     oneOf:
       - items:
+          - enum:
+              - ti,tmp110
+              - ti,tmp113
           - const: ti,tmp102
-          - const: ti,tmp103
-          - const: ti,tmp110
-      - enum:
-          - ti,tmp102
+      - const: ti,tmp102
+      - const: ti,tmp103
 
   interrupts:
     maxItems: 1
-- 
2.53.0

Re: [PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[sashiko-bot]

> The TMP113 temperature sensor part is register compatible with TMP102,
> document it using a fallback compatible. Unlike TMP102 and TMP110, the
> TMP113 does have additional unique ID registers, it is up to the driver
> to handle those.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901161008.46948-1-marex@nabladev.com?part=1

Re: [PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2595 bytes --]

On Tue, Sep 01, 2026 at 06:09:20PM +0200, Marek Vasut wrote:
> The TMP113 temperature sensor part is register compatible with TMP102,
> document it using a fallback compatible. Unlike TMP102 and TMP110, the
> TMP113 does have additional unique ID registers, it is up to the driver
> to handle those.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-hwmon@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> V2: Rebase on current next and resend, resolve a conflict with commit
>     d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
>     Note that the TMP102,110,113 are backward compatible, therefore the
>     valid compatible strings are:
>     - "ti,tmp110", "ti,tmp102"
>     - "ti,tmp113", "ti,tmp102"
>     - "ti,tmp102"
>     The TMP103 is not backward compatible, it only shares bindings now,
>     therefore the only valid compatible string for the TMP103 should be:
>     - "ti,tmp103"
>     And that is all, no other compatible strings are acceptable here.
> ---
>  .../devicetree/bindings/hwmon/ti,tmp102.yaml          | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> index 55d9f106465d7..c0b747a9ce0de 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: TMP102/TMP103/TMP110 temperature sensor
> +title: TMP102/TMP103/TMP110/TMP113 temperature sensor
>  
>  maintainers:
>    - Krzysztof Kozlowski <krzk@kernel.org>
> @@ -13,11 +13,12 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> +          - enum:
> +              - ti,tmp110
> +              - ti,tmp113
>            - const: ti,tmp102
> -          - const: ti,tmp103
> -          - const: ti,tmp110
> -      - enum:
> -          - ti,tmp102
> +      - const: ti,tmp102
> +      - const: ti,tmp103

Should this not be two patches, one fixing the existing stuff and one
adding the 113?

>  
>    interrupts:
>      maxItems: 1
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[Marek Vasut]

On 9/1/26 7:37 PM, Conor Dooley wrote:
> On Tue, Sep 01, 2026 at 06:09:20PM +0200, Marek Vasut wrote:
>> The TMP113 temperature sensor part is register compatible with TMP102,
>> document it using a fallback compatible. Unlike TMP102 and TMP110, the
>> TMP113 does have additional unique ID registers, it is up to the driver
>> to handle those.
>>
>> Signed-off-by: Marek Vasut <marex@nabladev.com>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-hwmon@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> V2: Rebase on current next and resend, resolve a conflict with commit
>>      d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
>>      Note that the TMP102,110,113 are backward compatible, therefore the
>>      valid compatible strings are:
>>      - "ti,tmp110", "ti,tmp102"
>>      - "ti,tmp113", "ti,tmp102"
>>      - "ti,tmp102"
>>      The TMP103 is not backward compatible, it only shares bindings now,
>>      therefore the only valid compatible string for the TMP103 should be:
>>      - "ti,tmp103"
>>      And that is all, no other compatible strings are acceptable here.
>> ---
>>   .../devicetree/bindings/hwmon/ti,tmp102.yaml          | 11 ++++++-----
>>   1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
>> index 55d9f106465d7..c0b747a9ce0de 100644
>> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
>> @@ -4,7 +4,7 @@
>>   $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
>>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>>   
>> -title: TMP102/TMP103/TMP110 temperature sensor
>> +title: TMP102/TMP103/TMP110/TMP113 temperature sensor
>>   
>>   maintainers:
>>     - Krzysztof Kozlowski <krzk@kernel.org>
>> @@ -13,11 +13,12 @@ properties:
>>     compatible:
>>       oneOf:
>>         - items:
>> +          - enum:
>> +              - ti,tmp110
>> +              - ti,tmp113
>>             - const: ti,tmp102
>> -          - const: ti,tmp103
>> -          - const: ti,tmp110
>> -      - enum:
>> -          - ti,tmp102
>> +      - const: ti,tmp102
>> +      - const: ti,tmp103
> 
> Should this not be two patches, one fixing the existing stuff and one
> adding the 113?
I can send this as two, sure, will do in v3.

Re: [PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[Guenter Roeck]

On 9/1/26 10:37, Conor Dooley wrote:
> On Tue, Sep 01, 2026 at 06:09:20PM +0200, Marek Vasut wrote:
>> The TMP113 temperature sensor part is register compatible with TMP102,
>> document it using a fallback compatible. Unlike TMP102 and TMP110, the
>> TMP113 does have additional unique ID registers, it is up to the driver
>> to handle those.
>>
>> Signed-off-by: Marek Vasut <marex@nabladev.com>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-hwmon@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> V2: Rebase on current next and resend, resolve a conflict with commit
>>      d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
>>      Note that the TMP102,110,113 are backward compatible, therefore the
>>      valid compatible strings are:
>>      - "ti,tmp110", "ti,tmp102"
>>      - "ti,tmp113", "ti,tmp102"
>>      - "ti,tmp102"
>>      The TMP103 is not backward compatible, it only shares bindings now,
>>      therefore the only valid compatible string for the TMP103 should be:
>>      - "ti,tmp103"
>>      And that is all, no other compatible strings are acceptable here.
>> ---
>>   .../devicetree/bindings/hwmon/ti,tmp102.yaml          | 11 ++++++-----
>>   1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
>> index 55d9f106465d7..c0b747a9ce0de 100644
>> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
>> @@ -4,7 +4,7 @@
>>   $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
>>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>>   
>> -title: TMP102/TMP103/TMP110 temperature sensor
>> +title: TMP102/TMP103/TMP110/TMP113 temperature sensor
>>   
>>   maintainers:
>>     - Krzysztof Kozlowski <krzk@kernel.org>
>> @@ -13,11 +13,12 @@ properties:
>>     compatible:
>>       oneOf:
>>         - items:
>> +          - enum:
>> +              - ti,tmp110
>> +              - ti,tmp113
>>             - const: ti,tmp102
>> -          - const: ti,tmp103
>> -          - const: ti,tmp110
>> -      - enum:
>> -          - ti,tmp102
>> +      - const: ti,tmp102
>> +      - const: ti,tmp103
> 
> Should this not be two patches, one fixing the existing stuff and one
> adding the 113?
> 

It is all in -next. Looks like I resolved the conflict when combining
"dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml"
and "dt-bindings: hwmon: tmp102: Document TMP110" the wrong way.
Sorry for that.

Instead of adding more patches on top of it, how about providing a
single patch moving tmp103 and adding tmp110 as well as tmp113
together ? Alternatively, I could drop "dt-bindings: hwmon: tmp102:
Document TMP110", apply the original (non-conflicting version) of
"dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml",
and then tmp110 and tmp113 could be added in a single patch.

Please let me know.

Thanks,
Guenter

Re: [PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[Marek Vasut]

On 9/1/26 7:48 PM, Guenter Roeck wrote:

Hello Guenter,

>>> @@ -13,11 +13,12 @@ properties:
>>>     compatible:
>>>       oneOf:
>>>         - items:
>>> +          - enum:
>>> +              - ti,tmp110
>>> +              - ti,tmp113
>>>             - const: ti,tmp102
>>> -          - const: ti,tmp103
>>> -          - const: ti,tmp110
>>> -      - enum:
>>> -          - ti,tmp102
>>> +      - const: ti,tmp102
>>> +      - const: ti,tmp103
>>
>> Should this not be two patches, one fixing the existing stuff and one
>> adding the 113?
>>
> 
> It is all in -next. Looks like I resolved the conflict when combining
> "dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml"
> and "dt-bindings: hwmon: tmp102: Document TMP110" the wrong way.
> Sorry for that.

No worries, I hope V3 I just sent fixes it up.

> Instead of adding more patches on top of it, how about providing a
> single patch moving tmp103 and adding tmp110 as well as tmp113
> together ? Alternatively, I could drop "dt-bindings: hwmon: tmp102:
> Document TMP110", apply the original (non-conflicting version) of
> "dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml",
> and then tmp110 and tmp113 could be added in a single patch.
> 
> Please let me know.
I think the broken commit is d67ec24d3f07 ("dt-bindings: hwmon: tmp102: 
move ti,tmp103 out of trivial-devices.yaml") and v3 1/2 is the fix for 
that broken commit. V3 2/2 only adds the missing TMP113 .

So I think there are two options:
- The complicated one -- squash d67ec24d3f07 ("dt-bindings: hwmon: 
tmp102: move ti,tmp103 out of trivial-devices.yaml") and V3 1/2 (and 
either do it in tree, or drop d67ec24d3f07 ("dt-bindings: hwmon: tmp102: 
move ti,tmp103 out of trivial-devices.yaml") and ask for it to be 
updated and resent), then apply that, and apply V3 2/2 (or newer) .
- The simple one -- apply both V3 patches (or whatever newer version is 
good enough) and move on.

Just let me know what you like better.

Re: [PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2276 bytes --]

On Tue, Sep 01, 2026 at 07:58:51PM +0200, Marek Vasut wrote:
> On 9/1/26 7:48 PM, Guenter Roeck wrote:
> 
> Hello Guenter,
> 
> > > > @@ -13,11 +13,12 @@ properties:
> > > >     compatible:
> > > >       oneOf:
> > > >         - items:
> > > > +          - enum:
> > > > +              - ti,tmp110
> > > > +              - ti,tmp113
> > > >             - const: ti,tmp102
> > > > -          - const: ti,tmp103
> > > > -          - const: ti,tmp110
> > > > -      - enum:
> > > > -          - ti,tmp102
> > > > +      - const: ti,tmp102
> > > > +      - const: ti,tmp103
> > > 
> > > Should this not be two patches, one fixing the existing stuff and one
> > > adding the 113?
> > > 
> > 
> > It is all in -next. Looks like I resolved the conflict when combining
> > "dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml"
> > and "dt-bindings: hwmon: tmp102: Document TMP110" the wrong way.
> > Sorry for that.
> 
> No worries, I hope V3 I just sent fixes it up.
> 
> > Instead of adding more patches on top of it, how about providing a
> > single patch moving tmp103 and adding tmp110 as well as tmp113
> > together ? Alternatively, I could drop "dt-bindings: hwmon: tmp102:
> > Document TMP110", apply the original (non-conflicting version) of
> > "dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml",
> > and then tmp110 and tmp113 could be added in a single patch.
> > 
> > Please let me know.
> I think the broken commit is d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move
> ti,tmp103 out of trivial-devices.yaml") and v3 1/2 is the fix for that
> broken commit. V3 2/2 only adds the missing TMP113 .
> 
> So I think there are two options:
> - The complicated one -- squash d67ec24d3f07 ("dt-bindings: hwmon: tmp102:
> move ti,tmp103 out of trivial-devices.yaml") and V3 1/2 (and either do it in
> tree, or drop d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out
> of trivial-devices.yaml") and ask for it to be updated and resent), then
> apply that, and apply V3 2/2 (or newer) .
> - The simple one -- apply both V3 patches (or whatever newer version is good
> enough) and move on.
> 
> Just let me know what you like better.

Either works for me fwiw, v3 looks fine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[Guenter Roeck]

On 9/1/26 10:58, Marek Vasut wrote:
> On 9/1/26 7:48 PM, Guenter Roeck wrote:
> 
> Hello Guenter,
> 
>>>> @@ -13,11 +13,12 @@ properties:
>>>>     compatible:
>>>>       oneOf:
>>>>         - items:
>>>> +          - enum:
>>>> +              - ti,tmp110
>>>> +              - ti,tmp113
>>>>             - const: ti,tmp102
>>>> -          - const: ti,tmp103
>>>> -          - const: ti,tmp110
>>>> -      - enum:
>>>> -          - ti,tmp102
>>>> +      - const: ti,tmp102
>>>> +      - const: ti,tmp103
>>>
>>> Should this not be two patches, one fixing the existing stuff and one
>>> adding the 113?
>>>
>>
>> It is all in -next. Looks like I resolved the conflict when combining
>> "dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml"
>> and "dt-bindings: hwmon: tmp102: Document TMP110" the wrong way.
>> Sorry for that.
> 
> No worries, I hope V3 I just sent fixes it up.
> 
>> Instead of adding more patches on top of it, how about providing a
>> single patch moving tmp103 and adding tmp110 as well as tmp113
>> together ? Alternatively, I could drop "dt-bindings: hwmon: tmp102:
>> Document TMP110", apply the original (non-conflicting version) of
>> "dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml",
>> and then tmp110 and tmp113 could be added in a single patch.
>>
>> Please let me know.
> I think the broken commit is d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml") and v3 1/2 is the fix for that broken commit. V3 2/2 only adds the missing TMP113 .
> 
> So I think there are two options:
> - The complicated one -- squash d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml") and V3 1/2 (and either do it in tree, or drop d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml") and ask for it to be updated and resent), then apply that, and apply V3 2/2 (or newer) .

I'll do that, assuming that Conor is ok with both patches.
No need to resend anything.

Thanks,
Guenter