Re: [PATCH v7 1/9] dt-bindings: mmc: add Cadence SD6HC binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Custom properties ending in `-ps` silently fail to enforce `minimum` and `maximum` bounds due to implicit array typing by dt-schema.
--

commit 26eb3b1bd7c793df986336bb3146ad20c9cf5ca6
Author: Tanmay Kathpalia <tanmay.kathpalia@altera.com>

dt-bindings: mmc: add Cadence SD6HC binding

This commit introduces the device tree binding for the Cadence SD6HC 
SD/SDIO/eMMC host controller. It defines the required clock domains, resets, 
and specific PHY timing properties.

> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sd6hc.yaml b/Documentation/devicetree/bindings/mmc/cdns,sd6hc.yaml
> new file mode 100644
> index 0000000000000..d5ea2717904b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sd6hc.yaml
[ ... ]
> +properties:
[ ... ]
> +  cdns,iocell-input-delay-ps:
> +    description:
> +      Input delay across the IO cells, used for SD6HC PHY timing calculations.
> +    minimum: 0
> +    maximum: 20000
> +    default: 2500
> +
> +  cdns,iocell-output-delay-ps:
> +    description:
> +      Output delay across the IO cells, used for SD6HC PHY timing calculations.
> +    minimum: 0
> +    maximum: 20000
> +    default: 2500
> +
> +  cdns,delay-element-ps:
> +    description:
> +      DLL delay element size, used for SD6HC PHY timing calculations.
> +    minimum: 1
> +    maximum: 1000
> +    default: 24

[Severity: Low]
Will the dt-schema validator actually enforce these minimum and maximum
bounds?

Because these properties use standard unit suffixes (-ps), the dt-schema
tooling implicitly types them as arrays (specifically, uint32-matrix).
In JSON Schema, the minimum and maximum keywords are strictly evaluated
only for numeric instances.

Since properties are parsed as array instances rather than scalar numbers,
these top-level numeric bounds are silently ignored by the JSON Schema
validator.

Could this be fixed by explicitly defining 
$ref: /schemas/types.yaml#/definitions/uint32 to override the default array
type and enforce a scalar integer, or by placing the bounds within an items
validation block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901184828.15653-1-tanmay.kathpalia@altera.com?part=1