Re: [PATCH v7 3/9] arm64: dts: agilex5: enable SD card on SOCDK OOBE card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Device tree node overrides are not sorted alphabetically by label.
- [Low] Missing `no-sdio` property for SD-only slot.
--

commit eddece91ac39f2531713c8f5e5e5490392d405bb
Author: Tanmay Kathpalia <tanmay.kathpalia@altera.com>

arm64: dts: agilex5: enable SD card on SOCDK OOBE card

This patch configures the device tree to enable the SD card on the SOCDK 
OOBE board. It adds voltage regulators for the 3.3V and 1.8V supplies 
and sets up the sdmmc node with the necessary high-speed capabilities.

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> index 57d3c5807c65c..2b753d0e17bb7 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts

[ ... ]

> -&gpio0 {
> +&sdmmc {

[Severity: Low]
Is the placement of the &sdmmc node intended here? 

The device tree style convention typically expects node overrides to be sorted
alphabetically by label. Placing it here breaks that sorting order, which could
lead to merge conflicts or maintainability issues later on.

> +	bus-width = <4>;
> +	cap-sd-highspeed;
> +	disable-wp;
> +	max-frequency = <200000000>;
> +	no-mmc;

[Severity: Low]
Since the commit message indicates this is an SD-only slot, should we also 
include the no-sdio property here?

By omitting no-sdio, the MMC core might still issue SDIO initialization 
commands (like cmd5) during card enumeration. Adding no-sdio alongside no-mmc
would prevent these unnecessary probing commands and avoid minor delays during 
boot and card insertion.

> +	sd-uhs-sdr104;
> +	vmmc-supply = <&vmmc_reg>;
> +	vqmmc-supply = <&vqmmc_io_reg>;
> +
>  	status = "okay";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901184828.15653-1-tanmay.kathpalia@altera.com?part=3