* [PATCH 0/2] hwmon: (pmbus/tps53679) Add TPS53622 and TPS53659 @ 2026-09-01 21:11 Pradhan, Sanman 2026-09-01 21:11 ` [PATCH 1/2] dt-bindings: trivial-devices: Add TI " Pradhan, Sanman 2026-09-01 21:11 ` [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for " Pradhan, Sanman 0 siblings, 2 replies; 8+ messages in thread From: Pradhan, Sanman @ 2026-09-01 21:11 UTC (permalink / raw) To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet Cc: devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sanman Pradhan From: Sanman Pradhan <psanman@juniper.net> TPS53622 and TPS53659 are TI dual-channel D-CAP+ step-down controllers that use the VID VOUT format and VOUT_MODE identification like the already-supported TPS53679/TPS53688, so they reuse tps53679_identify(). Patch 1 adds the compatible strings; patch 2 adds the chip IDs, shortens the Kconfig prompt to the family name (and lists the already-supported TPS53685, previously missing from it), updates the driver documentation and fixes an existing "TPS53588" typo in the attribute tables. Tested on Juniper hardware. Sanman Pradhan (2): dt-bindings: trivial-devices: Add TI TPS53622 and TPS53659 hwmon: (pmbus/tps53679) Add support for TPS53622 and TPS53659 .../devicetree/bindings/trivial-devices.yaml | 4 ++++ Documentation/hwmon/tps53679.rst | 24 +++++++++++++++---- drivers/hwmon/pmbus/Kconfig | 5 ++-- drivers/hwmon/pmbus/tps53679.c | 9 ++++++- 4 files changed, 35 insertions(+), 7 deletions(-) base-commit: 40c9f01347ad94a1f9346313226d788afcf1366b -- 2.34.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: trivial-devices: Add TI TPS53622 and TPS53659 2026-09-01 21:11 [PATCH 0/2] hwmon: (pmbus/tps53679) Add TPS53622 and TPS53659 Pradhan, Sanman @ 2026-09-01 21:11 ` Pradhan, Sanman 2026-09-01 21:14 ` sashiko-bot ` (2 more replies) 2026-09-01 21:11 ` [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for " Pradhan, Sanman 1 sibling, 3 replies; 8+ messages in thread From: Pradhan, Sanman @ 2026-09-01 21:11 UTC (permalink / raw) To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet Cc: devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sanman Pradhan From: Sanman Pradhan <psanman@juniper.net> TPS53622 and TPS53659 are PMBus-compliant D-CAP+ multiphase step-down controllers. Add their compatible strings. Signed-off-by: Sanman Pradhan <psanman@juniper.net> --- Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 6229a6516302..94e63d8a58ad 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -512,8 +512,12 @@ properties: - ti,tmp125 # TI DC-DC converter on PMBus - ti,tps40400 + # TI Dual channel DCAP+ multiphase controller TPS53622 + - ti,tps53622 # TI DCAP+ multiphase controller - ti,tps53647 + # TI Dual channel DCAP+ multiphase controller TPS53659 + - ti,tps53659 # TI DCAP+ multiphase controller - ti,tps53667 # TI Dual channel DCAP+ multiphase controller TPS53676 with AVSBus -- 2.34.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: trivial-devices: Add TI TPS53622 and TPS53659 2026-09-01 21:11 ` [PATCH 1/2] dt-bindings: trivial-devices: Add TI " Pradhan, Sanman @ 2026-09-01 21:14 ` sashiko-bot 2026-09-02 18:05 ` Conor Dooley 2026-09-02 21:38 ` Guenter Roeck 2 siblings, 0 replies; 8+ messages in thread From: sashiko-bot @ 2026-09-01 21:14 UTC (permalink / raw) To: Pradhan, Sanman; +Cc: devicetree, conor+dt, linux-hwmon, robh > From: Sanman Pradhan <psanman@juniper.net> > > TPS53622 and TPS53659 are PMBus-compliant D-CAP+ multiphase step-down > controllers. Add their compatible strings. > > Signed-off-by: Sanman Pradhan <psanman@juniper.net> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/20260901211129.360792-1-sanman.pradhan@hpe.com?part=1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: trivial-devices: Add TI TPS53622 and TPS53659 2026-09-01 21:11 ` [PATCH 1/2] dt-bindings: trivial-devices: Add TI " Pradhan, Sanman 2026-09-01 21:14 ` sashiko-bot @ 2026-09-02 18:05 ` Conor Dooley 2026-09-02 21:38 ` Guenter Roeck 2 siblings, 0 replies; 8+ messages in thread From: Conor Dooley @ 2026-09-02 18:05 UTC (permalink / raw) To: Pradhan, Sanman Cc: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sanman Pradhan [-- Attachment #1: Type: text/plain, Size: 75 bytes --] Acked-by: Conor Dooley <conor.dooley@microchip.com> pw-bot: not-applicable [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: trivial-devices: Add TI TPS53622 and TPS53659 2026-09-01 21:11 ` [PATCH 1/2] dt-bindings: trivial-devices: Add TI " Pradhan, Sanman 2026-09-01 21:14 ` sashiko-bot 2026-09-02 18:05 ` Conor Dooley @ 2026-09-02 21:38 ` Guenter Roeck 2 siblings, 0 replies; 8+ messages in thread From: Guenter Roeck @ 2026-09-02 21:38 UTC (permalink / raw) To: Pradhan, Sanman Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sanman Pradhan On Tue, Sep 01, 2026 at 09:11:48PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan <psanman@juniper.net> > > TPS53622 and TPS53659 are PMBus-compliant D-CAP+ multiphase step-down > controllers. Add their compatible strings. > > Signed-off-by: Sanman Pradhan <psanman@juniper.net> > Acked-by: Conor Dooley <conor.dooley@microchip.com> Applied. Thanks, Guenter ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for TPS53622 and TPS53659 2026-09-01 21:11 [PATCH 0/2] hwmon: (pmbus/tps53679) Add TPS53622 and TPS53659 Pradhan, Sanman 2026-09-01 21:11 ` [PATCH 1/2] dt-bindings: trivial-devices: Add TI " Pradhan, Sanman @ 2026-09-01 21:11 ` Pradhan, Sanman 2026-09-01 21:20 ` sashiko-bot 2026-09-02 21:38 ` Guenter Roeck 1 sibling, 2 replies; 8+ messages in thread From: Pradhan, Sanman @ 2026-09-01 21:11 UTC (permalink / raw) To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet Cc: devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sanman Pradhan From: Sanman Pradhan <psanman@juniper.net> TPS53622 and TPS53659 are dual-channel D-CAP+ step-down controllers that use the VID VOUT format and VOUT_MODE identification like the existing TPS53679/TPS53688, so they reuse tps53679_identify(). Shorten the Kconfig prompt to the family name and list the supported chips in the help text instead; this also adds TPS53685, which is already supported by the driver but was missing from the list. Update the driver documentation, including the per-attribute lists, and fix an existing "TPS53588" typo (should be TPS53688) in those lists. Signed-off-by: Sanman Pradhan <psanman@juniper.net> --- Documentation/hwmon/tps53679.rst | 24 ++++++++++++++++++++---- drivers/hwmon/pmbus/Kconfig | 5 +++-- drivers/hwmon/pmbus/tps53679.c | 9 ++++++++- 3 files changed, 31 insertions(+), 7 deletions(-) diff --git a/Documentation/hwmon/tps53679.rst b/Documentation/hwmon/tps53679.rst index dd5e4a37375d..2280e043c4de 100644 --- a/Documentation/hwmon/tps53679.rst +++ b/Documentation/hwmon/tps53679.rst @@ -3,6 +3,14 @@ Kernel driver tps53679 Supported chips: + * Texas Instruments TPS53622 + + Prefix: 'tps53622' + + Addresses scanned: - + + Datasheet: https://www.ti.com/lit/gpn/TPS53622 + * Texas Instruments TPS53647 Prefix: 'tps53647' @@ -11,6 +19,14 @@ Supported chips: Datasheet: https://www.ti.com/lit/gpn/tps53647 + * Texas Instruments TPS53659 + + Prefix: 'tps53659' + + Addresses scanned: - + + Datasheet: https://www.ti.com/lit/gpn/TPS53659 + * Texas Instruments TPS53667 Prefix: 'tps53667' @@ -108,7 +124,7 @@ in1_crit_alarm Input voltage critical high alarm. in[N]_label "vout[1-2]" - TPS53647, TPS53667: N=2 - - TPS53679, TPS53588: N=2,3 + - TPS53622, TPS53659, TPS53679, TPS53688: N=2,3 in[N]_input Measured output voltage. @@ -135,7 +151,7 @@ in[N]_crit_alarm Output voltage critical high alarm. temp[N]_input Measured temperature. - TPS53647, TPS53667: N=1 - - TPS53679, TPS53681, TPS53588: N=1,2 + - TPS53622, TPS53659, TPS53679, TPS53681, TPS53688: N=1,2 temp[N]_max Maximum temperature. @@ -152,7 +168,7 @@ power1_input Measured input power. power[N]_label "pout[1-2]". - TPS53647, TPS53667: N=2 - - TPS53676, TPS53679, TPS53681, TPS53588: N=2,3 + - TPS53622, TPS53659, TPS53676, TPS53679, TPS53681, TPS53688: N=2,3 power[N]_input Measured output power. @@ -175,7 +191,7 @@ curr[N]_label "iout[1-2]" or "iout1.[0-5]". telemetry supported on TPS53676 and TPS53681 only. - TPS53647, TPS53667: N=2 - - TPS53679, TPS53588: N=2,3 + - TPS53622, TPS53659, TPS53679, TPS53688: N=2,3 - TPS53676: N=2-8 - TPS53681: N=2-9 diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig index eb71a0ac044b..bcfdc4ce4c10 100644 --- a/drivers/hwmon/pmbus/Kconfig +++ b/drivers/hwmon/pmbus/Kconfig @@ -790,10 +790,11 @@ config SENSORS_TPS40422 be called tps40422. config SENSORS_TPS53679 - tristate "TI TPS53647, TPS53667, TPS53676, TPS53679, TPS53681, TPS53688" + tristate "TI TPS536xx family" help If you say yes here you get hardware monitoring support for TI - TPS53647, TPS53667, TPS53676, TPS53679, TPS53681, and TPS53688. + TPS53622, TPS53647, TPS53659, TPS53667, TPS53676, TPS53679, TPS53681, + TPS53685, and TPS53688. This driver can also be built as a module. If so, the module will be called tps53679. diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c index 31e54608b3c9..fa0fdf1e3e6c 100644 --- a/drivers/hwmon/pmbus/tps53679.c +++ b/drivers/hwmon/pmbus/tps53679.c @@ -16,7 +16,8 @@ #include "pmbus.h" enum chips { - tps53647, tps53667, tps53676, tps53679, tps53681, tps53685, tps53688 + tps53622, tps53647, tps53659, tps53667, tps53676, tps53679, tps53681, + tps53685, tps53688 }; #define TPS53647_PAGE_NUM 1 @@ -268,6 +269,8 @@ static int tps53679_probe(struct i2c_client *client) case tps53676: info->identify = tps53676_identify; break; + case tps53622: + case tps53659: case tps53679: case tps53688: info->pages = TPS53679_PAGE_NUM; @@ -292,7 +295,9 @@ static int tps53679_probe(struct i2c_client *client) static const struct i2c_device_id tps53679_id[] = { { .name = "bmr474", .driver_data = tps53676 }, + { .name = "tps53622", .driver_data = tps53622 }, { .name = "tps53647", .driver_data = tps53647 }, + { .name = "tps53659", .driver_data = tps53659 }, { .name = "tps53667", .driver_data = tps53667 }, { .name = "tps53676", .driver_data = tps53676 }, { .name = "tps53679", .driver_data = tps53679 }, @@ -305,7 +310,9 @@ static const struct i2c_device_id tps53679_id[] = { MODULE_DEVICE_TABLE(i2c, tps53679_id); static const struct of_device_id __maybe_unused tps53679_of_match[] = { + {.compatible = "ti,tps53622", .data = (void *)tps53622}, {.compatible = "ti,tps53647", .data = (void *)tps53647}, + {.compatible = "ti,tps53659", .data = (void *)tps53659}, {.compatible = "ti,tps53667", .data = (void *)tps53667}, {.compatible = "ti,tps53676", .data = (void *)tps53676}, {.compatible = "ti,tps53679", .data = (void *)tps53679}, -- 2.34.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for TPS53622 and TPS53659 2026-09-01 21:11 ` [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for " Pradhan, Sanman @ 2026-09-01 21:20 ` sashiko-bot 2026-09-02 21:38 ` Guenter Roeck 1 sibling, 0 replies; 8+ messages in thread From: sashiko-bot @ 2026-09-01 21:20 UTC (permalink / raw) To: Pradhan, Sanman; +Cc: robh, devicetree, linux-hwmon, conor+dt > From: Sanman Pradhan <psanman@juniper.net> > > TPS53622 and TPS53659 are dual-channel D-CAP+ step-down controllers that > use the VID VOUT format and VOUT_MODE identification like the existing > TPS53679/TPS53688, so they reuse tps53679_identify(). > > Shorten the Kconfig prompt to the family name and list the supported > chips in the help text instead; this also adds TPS53685, which is already > supported by the driver but was missing from the list. Update the driver > documentation, including the per-attribute lists, and fix an existing > "TPS53588" typo (should be TPS53688) in those lists. > > Signed-off-by: Sanman Pradhan <psanman@juniper.net> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/20260901211129.360792-1-sanman.pradhan@hpe.com?part=2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for TPS53622 and TPS53659 2026-09-01 21:11 ` [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for " Pradhan, Sanman 2026-09-01 21:20 ` sashiko-bot @ 2026-09-02 21:38 ` Guenter Roeck 1 sibling, 0 replies; 8+ messages in thread From: Guenter Roeck @ 2026-09-02 21:38 UTC (permalink / raw) To: Pradhan, Sanman Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sanman Pradhan On Tue, Sep 01, 2026 at 09:11:53PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan <psanman@juniper.net> > > TPS53622 and TPS53659 are dual-channel D-CAP+ step-down controllers that > use the VID VOUT format and VOUT_MODE identification like the existing > TPS53679/TPS53688, so they reuse tps53679_identify(). > > Shorten the Kconfig prompt to the family name and list the supported > chips in the help text instead; this also adds TPS53685, which is already > supported by the driver but was missing from the list. Update the driver > documentation, including the per-attribute lists, and fix an existing > "TPS53588" typo (should be TPS53688) in those lists. > > Signed-off-by: Sanman Pradhan <psanman@juniper.net> Applied. Thanks, Guenter ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-09-02 21:38 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-09-01 21:11 [PATCH 0/2] hwmon: (pmbus/tps53679) Add TPS53622 and TPS53659 Pradhan, Sanman 2026-09-01 21:11 ` [PATCH 1/2] dt-bindings: trivial-devices: Add TI " Pradhan, Sanman 2026-09-01 21:14 ` sashiko-bot 2026-09-02 18:05 ` Conor Dooley 2026-09-02 21:38 ` Guenter Roeck 2026-09-01 21:11 ` [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for " Pradhan, Sanman 2026-09-01 21:20 ` sashiko-bot 2026-09-02 21:38 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox