Re: [PATCH v2 2/4] dt-bindings: nvmem: layouts: Add Rockchip OTP CPUID layout

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The 'mac-address' NVMEM cell node provides phandle arguments but omits '#nvmem-cell-cells' from its required list.
--

commit fcf6d128e83a760e02cdd15150b742b14d86fe0d
Author: Alexey Charkov <alchark@flipper.net>

dt-bindings: nvmem: layouts: Add Rockchip OTP CPUID layout

This commit introduces a new NVMEM layout binding for the Rockchip OTP CPU ID.
It describes how the CPU ID is used to derive a stable Ethernet MAC address
and provides the corresponding device tree schema.

> diff --git a/Documentation/devicetree/bindings/nvmem/layouts/rockchip,rk3576-otp-cpuid.yaml b/Documentation/devicetree/bindings/nvmem/layouts/rockchip,rk3576-otp-cpuid.yaml
> new file mode 100644
> index 0000000000000..85153d480950a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/layouts/rockchip,rk3576-otp-cpuid.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: rockchip,rk3576-otp-cpuid
> +
> +  mac-address:
> +    type: object
> +    description:
> +      MAC address derived from the CPU ID. The first argument of the phandle
> +      selects one of the two addresses that can be derived (can be 0 or 1).
> +
> +    properties:
> +      "#nvmem-cell-cells":
> +        const: 1
> +
> +    additionalProperties: false

[Severity: Medium]
Since the mac-address NVMEM cell node provides phandle arguments and defines
#nvmem-cell-cells, should it also be included in a required list for this
node to enforce its presence?

Without this, incomplete mac-address nodes in device trees might silently
pass dt-schema validation but fail at runtime when the kernel attempts to
parse the NVMEM cell phandle arguments.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-rk3576-otp-cpuid-mac-v2-0-e4b7fe2ab13f@flipper.net?part=2