* [PATCH v5 3/4] iio: dac: ad3530r: parameterize DAC resolution
2026-09-04 8:35 [PATCH v5 0/4] Add support for AD5710R/AD5711R DAC Kim Seer Paller
2026-09-04 8:35 ` [PATCH v5 1/4] iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode Kim Seer Paller
2026-09-04 8:35 ` [PATCH v5 2/4] dt-bindings: iio: dac: add adi,ad5710r.yaml Kim Seer Paller
@ 2026-09-04 8:35 ` Kim Seer Paller
2026-09-04 8:35 ` [PATCH v5 4/4] iio: dac: ad3530r: add support for AD5710R/AD5711R Kim Seer Paller
3 siblings, 0 replies; 7+ messages in thread
From: Kim Seer Paller @ 2026-09-04 8:35 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Michael Hennerich, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Philipp Zabel
Cc: linux-iio, linux-kernel, linux, devicetree, Kim Seer Paller
In preparation for adding the AD5710R/AD5711R, which support selectable
12-/16-bit resolution, add a per-chip resolution field and use it in the
raw read/write and scale paths instead of assuming 16 bits. Drop
AD3530R_REG_VAL_MASK and AD3530R_DAC_MAX_VAL, which hardcoded the 16-bit
width and are now unused.
Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
---
drivers/iio/dac/ad3530r.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/dac/ad3530r.c b/drivers/iio/dac/ad3530r.c
index 06b7f280f61b..3056593a5ca0 100644
--- a/drivers/iio/dac/ad3530r.c
+++ b/drivers/iio/dac/ad3530r.c
@@ -61,14 +61,12 @@
#define AD3530R_SLD_TRIG_A BIT(7)
#define AD3530R_OUTPUT_CONTROL_RANGE BIT(2)
#define AD3530R_REFERENCE_CONTROL_SEL BIT(0)
-#define AD3530R_REG_VAL_MASK GENMASK(15, 0)
#define AD3530R_OP_MODE_CHAN_MSK(chan) (GENMASK(1, 0) << 2 * (chan))
#define AD3530R_SW_RESET (BIT(7) | BIT(0))
#define AD3530R_INTERNAL_VREF_mV 2500
#define AD3530R_LDAC_PULSE_US 100
-#define AD3530R_DAC_MAX_VAL GENMASK(15, 0)
#define AD3530R_CH_PER_REG 4
#define AD3530R_CH_PER_BANK 8
#define AD3531R_MAX_CHANNELS 4
@@ -99,6 +97,7 @@ struct ad3530r_chip_info {
unsigned int num_channels;
unsigned int num_banks;
unsigned int num_op_mode_regs;
+ unsigned int resolution;
bool internal_ref_support;
};
@@ -310,7 +309,7 @@ static int ad3530r_dac_write(struct ad3530r_state *st, unsigned int chan,
int ret;
guard(mutex)(&st->lock);
- st->buf = cpu_to_be16(val);
+ st->buf = cpu_to_be16(val << (16 - st->chip_info->resolution));
ret = regmap_bulk_write(st->regmap, st->chip_info->input_ch_reg(chan),
&st->buf, sizeof(st->buf));
@@ -340,12 +339,12 @@ static int ad3530r_read_raw(struct iio_dev *indio_dev,
if (ret)
return ret;
- *val = FIELD_GET(AD3530R_REG_VAL_MASK, be16_to_cpu(st->buf));
+ *val = be16_to_cpu(st->buf) >> (16 - st->chip_info->resolution);
return IIO_VAL_INT;
case IIO_CHAN_INFO_SCALE:
*val = st->vref_mV;
- *val2 = 16;
+ *val2 = st->chip_info->resolution;
return IIO_VAL_FRACTIONAL_LOG2;
default:
@@ -361,7 +360,7 @@ static int ad3530r_write_raw(struct iio_dev *indio_dev,
switch (info) {
case IIO_CHAN_INFO_RAW:
- if (val < 0 || val > AD3530R_DAC_MAX_VAL)
+ if (val < 0 || val > GENMASK(st->chip_info->resolution - 1, 0))
return -EINVAL;
return ad3530r_dac_write(st, chan->channel, val);
@@ -525,6 +524,7 @@ static const struct regmap_config ad3532r_regmap_config = {
static const struct ad3530r_chip_info ad3530_chip = {
.name = "ad3530",
+ .resolution = 16,
.channels = ad3530r_channels,
.regmap_config = &ad3530r_regmap_config,
.num_channels = ARRAY_SIZE(ad3530r_channels),
@@ -541,6 +541,7 @@ static const struct ad3530r_chip_info ad3530_chip = {
static const struct ad3530r_chip_info ad3530r_chip = {
.name = "ad3530r",
+ .resolution = 16,
.channels = ad3530r_channels,
.regmap_config = &ad3530r_regmap_config,
.num_channels = ARRAY_SIZE(ad3530r_channels),
@@ -557,6 +558,7 @@ static const struct ad3530r_chip_info ad3530r_chip = {
static const struct ad3530r_chip_info ad3531_chip = {
.name = "ad3531",
+ .resolution = 16,
.channels = ad3531r_channels,
.regmap_config = &ad3530r_regmap_config,
.num_channels = ARRAY_SIZE(ad3531r_channels),
@@ -573,6 +575,7 @@ static const struct ad3530r_chip_info ad3531_chip = {
static const struct ad3530r_chip_info ad3531r_chip = {
.name = "ad3531r",
+ .resolution = 16,
.channels = ad3531r_channels,
.regmap_config = &ad3530r_regmap_config,
.num_channels = ARRAY_SIZE(ad3531r_channels),
@@ -589,6 +592,7 @@ static const struct ad3530r_chip_info ad3531r_chip = {
static const struct ad3530r_chip_info ad3532_chip = {
.name = "ad3532",
+ .resolution = 16,
.channels = ad3532r_channels,
.regmap_config = &ad3532r_regmap_config,
.num_channels = ARRAY_SIZE(ad3532r_channels),
@@ -605,6 +609,7 @@ static const struct ad3530r_chip_info ad3532_chip = {
static const struct ad3530r_chip_info ad3532r_chip = {
.name = "ad3532r",
+ .resolution = 16,
.channels = ad3532r_channels,
.regmap_config = &ad3532r_regmap_config,
.num_channels = ARRAY_SIZE(ad3532r_channels),
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v5 4/4] iio: dac: ad3530r: add support for AD5710R/AD5711R
2026-09-04 8:35 [PATCH v5 0/4] Add support for AD5710R/AD5711R DAC Kim Seer Paller
` (2 preceding siblings ...)
2026-09-04 8:35 ` [PATCH v5 3/4] iio: dac: ad3530r: parameterize DAC resolution Kim Seer Paller
@ 2026-09-04 8:35 ` Kim Seer Paller
3 siblings, 0 replies; 7+ messages in thread
From: Kim Seer Paller @ 2026-09-04 8:35 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Michael Hennerich, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Philipp Zabel
Cc: linux-iio, linux-kernel, linux, devicetree, Kim Seer Paller
Add support for the AD5710R/AD5711R, 8-channel 16-/12-bit configurable
IDAC/VDAC parts. They share the AD3530R register map and access model,
so fold them into this driver.
Each channel is configured as voltage or current output from its DT
channel@N node via adi,ch-func, building the iio_chan_spec dynamically.
Voltage channels enable VMODE_EN and report the reference-derived scale,
current channels report the 50 mA internal Iref scale. The powerdown
mode is read-only and derived from the channel's configured type.
Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
---
drivers/iio/dac/Kconfig | 1 +
drivers/iio/dac/ad3530r.c | 283 +++++++++++++++++++++++++++++++++++++++++++---
2 files changed, 267 insertions(+), 17 deletions(-)
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 3b3c77d8b3e1..f108d5bac572 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -16,6 +16,7 @@ config AD3530R
- AD3530/AD3530R (8-channel)
- AD3531/AD3531R (4-channel)
- AD3532/AD3532R (16-channel)
+ - AD5710R/AD5711R (8-channel configurable IDAC/VDAC)
To compile this driver as a module, choose M here: the
module will be called ad3530r.
diff --git a/drivers/iio/dac/ad3530r.c b/drivers/iio/dac/ad3530r.c
index 3056593a5ca0..7648aa4da25a 100644
--- a/drivers/iio/dac/ad3530r.c
+++ b/drivers/iio/dac/ad3530r.c
@@ -3,8 +3,10 @@
* AD3530R/AD3530 8-channel, 16-bit Voltage Output DAC Driver
* AD3531R/AD3531 4-channel, 16-bit Voltage Output DAC Driver
* AD3532R/AD3532 16-channel, 16-bit Voltage Output DAC Driver
+ * AD5710R 8-channel, 16-bit Configurable IDAC/VDAC Driver
+ * AD5711R 8-channel, 12-bit Configurable IDAC/VDAC Driver
*
- * Copyright 2025 Analog Devices Inc.
+ * Copyright 2025-2026 Analog Devices Inc.
*/
#include <linux/array_size.h>
@@ -27,6 +29,8 @@
#include <linux/types.h>
#include <linux/units.h>
+#include <dt-bindings/iio/addac/adi,ad74413r.h>
+
#define AD3530R_INTERFACE_CONFIG_A 0x00
#define AD3530R_OUTPUT_OPERATING_MODE_0 0x20
#define AD3530R_OUTPUT_OPERATING_MODE_1 0x21
@@ -39,6 +43,8 @@
#define AD3531R_SW_LDAC_TRIG_A 0xDD
#define AD3531R_INPUT_CH 0xE3
+#define AD5710R_CHN_VMODE_EN 0xFF
+
/* AD3532R/AD3532 bank 0 registers (channels 0-7) */
#define AD3532R_INTERFACE_CONFIG_A_0 0x1000
#define AD3532R_OUTPUT_OPERATING_MODE_0 0x1020
@@ -62,9 +68,11 @@
#define AD3530R_OUTPUT_CONTROL_RANGE BIT(2)
#define AD3530R_REFERENCE_CONTROL_SEL BIT(0)
#define AD3530R_OP_MODE_CHAN_MSK(chan) (GENMASK(1, 0) << 2 * (chan))
+#define AD5710R_CHN_VMODE_EN_BIT(chan) BIT(chan)
#define AD3530R_SW_RESET (BIT(7) | BIT(0))
#define AD3530R_INTERNAL_VREF_mV 2500
+#define AD5710R_INTERNAL_IREF_mA 50
#define AD3530R_LDAC_PULSE_US 100
#define AD3530R_CH_PER_REG 4
@@ -99,6 +107,7 @@ struct ad3530r_chip_info {
unsigned int num_op_mode_regs;
unsigned int resolution;
bool internal_ref_support;
+ bool configurable_ch_func;
};
struct ad3530r_state {
@@ -194,6 +203,23 @@ static const struct iio_enum ad3532r_powerdown_mode_enum = {
.set = ad3530r_set_powerdown_mode,
};
+static ssize_t ad5710r_read_powerdown_mode(struct iio_dev *indio_dev,
+ uintptr_t private,
+ const struct iio_chan_spec *chan,
+ char *buf)
+{
+ struct ad3530r_state *st = iio_priv(indio_dev);
+ int ret;
+
+ /* Voltage output pulls to 15kohm_to_gnd, current goes three_state. */
+ ret = regmap_test_bits(st->regmap, AD5710R_CHN_VMODE_EN,
+ AD5710R_CHN_VMODE_EN_BIT(chan->channel));
+ if (ret < 0)
+ return ret;
+
+ return sysfs_emit(buf, "%s\n", ret ? "15kohm_to_gnd" : "three_state");
+}
+
static ssize_t ad3530r_get_dac_powerdown(struct iio_dev *indio_dev,
uintptr_t private,
const struct iio_chan_spec *chan,
@@ -277,6 +303,61 @@ static ssize_t ad3532r_set_dac_powerdown(struct iio_dev *indio_dev,
return len;
}
+static void ad5710r_get_op_mode_reg(unsigned int channel, unsigned int *reg,
+ unsigned int *mask)
+{
+ unsigned int local_ch, reg_in_bank, ch_in_reg;
+
+ local_ch = channel % AD3530R_CH_PER_BANK;
+ reg_in_bank = local_ch / AD3530R_CH_PER_REG;
+ ch_in_reg = local_ch % AD3530R_CH_PER_REG;
+
+ *reg = AD3530R_OUTPUT_OPERATING_MODE_0 + reg_in_bank;
+ *mask = AD3530R_OP_MODE_CHAN_MSK(ch_in_reg);
+}
+
+static ssize_t ad5710r_get_dac_powerdown(struct iio_dev *indio_dev,
+ uintptr_t private,
+ const struct iio_chan_spec *chan,
+ char *buf)
+{
+ struct ad3530r_state *st = iio_priv(indio_dev);
+ unsigned int reg, mask;
+ int ret;
+
+ ad5710r_get_op_mode_reg(chan->channel, ®, &mask);
+
+ ret = regmap_test_bits(st->regmap, reg, field_prep(mask, 1));
+ if (ret < 0)
+ return ret;
+
+ return sysfs_emit(buf, "%d\n", ret);
+}
+
+static ssize_t ad5710r_set_dac_powerdown(struct iio_dev *indio_dev,
+ uintptr_t private,
+ const struct iio_chan_spec *chan,
+ const char *buf, size_t len)
+{
+ struct ad3530r_state *st = iio_priv(indio_dev);
+ unsigned int reg, mask;
+ bool powerdown;
+ int ret;
+
+ ret = kstrtobool(buf, &powerdown);
+ if (ret)
+ return ret;
+
+ ad5710r_get_op_mode_reg(chan->channel, ®, &mask);
+
+ ret = regmap_update_bits(st->regmap, reg, mask,
+ field_prep(mask, powerdown));
+ if (ret)
+ return ret;
+
+ return len;
+}
+
static int ad3530r_trigger_sw_ldac_reg(unsigned int channel)
{
return AD3530R_SW_LDAC_TRIG_A;
@@ -343,7 +424,10 @@ static int ad3530r_read_raw(struct iio_dev *indio_dev,
return IIO_VAL_INT;
case IIO_CHAN_INFO_SCALE:
- *val = st->vref_mV;
+ if (chan->type == IIO_CURRENT)
+ *val = AD5710R_INTERNAL_IREF_mA;
+ else
+ *val = st->vref_mV;
*val2 = st->chip_info->resolution;
return IIO_VAL_FRACTIONAL_LOG2;
@@ -419,6 +503,21 @@ static const struct iio_chan_spec_ext_info ad3532r_ext_info[] = {
{ }
};
+static const struct iio_chan_spec_ext_info ad5710r_ext_info[] = {
+ {
+ .name = "powerdown",
+ .shared = IIO_SEPARATE,
+ .read = ad5710r_get_dac_powerdown,
+ .write = ad5710r_set_dac_powerdown,
+ },
+ {
+ .name = "powerdown_mode",
+ .shared = IIO_SEPARATE,
+ .read = ad5710r_read_powerdown_mode,
+ },
+ { }
+};
+
#define AD3530R_CHAN(_chan, _ext_info) \
{ \
.type = IIO_VOLTAGE, \
@@ -467,6 +566,17 @@ static const struct iio_chan_spec ad3532r_channels[] = {
AD3530R_CHAN(15, ad3532r_ext_info),
};
+static const struct iio_chan_spec ad5710r_channels[] = {
+ AD3530R_CHAN(0, ad5710r_ext_info),
+ AD3530R_CHAN(1, ad5710r_ext_info),
+ AD3530R_CHAN(2, ad5710r_ext_info),
+ AD3530R_CHAN(3, ad5710r_ext_info),
+ AD3530R_CHAN(4, ad5710r_ext_info),
+ AD3530R_CHAN(5, ad5710r_ext_info),
+ AD3530R_CHAN(6, ad5710r_ext_info),
+ AD3530R_CHAN(7, ad5710r_ext_info),
+};
+
static const unsigned int ad3530r_if_config[] = {
AD3530R_INTERFACE_CONFIG_A,
};
@@ -522,6 +632,12 @@ static const struct regmap_config ad3532r_regmap_config = {
.max_register = AD3532R_MAX_REG_ADDR,
};
+static const struct regmap_config ad5710r_regmap_config = {
+ .reg_bits = 16,
+ .val_bits = 8,
+ .max_register = AD5710R_CHN_VMODE_EN,
+};
+
static const struct ad3530r_chip_info ad3530_chip = {
.name = "ad3530",
.resolution = 16,
@@ -537,6 +653,7 @@ static const struct ad3530r_chip_info ad3530_chip = {
.num_banks = ARRAY_SIZE(ad3530r_if_config),
.num_op_mode_regs = ARRAY_SIZE(ad3530r_op_mode),
.internal_ref_support = false,
+ .configurable_ch_func = false,
};
static const struct ad3530r_chip_info ad3530r_chip = {
@@ -554,6 +671,7 @@ static const struct ad3530r_chip_info ad3530r_chip = {
.num_banks = ARRAY_SIZE(ad3530r_if_config),
.num_op_mode_regs = ARRAY_SIZE(ad3530r_op_mode),
.internal_ref_support = true,
+ .configurable_ch_func = false,
};
static const struct ad3530r_chip_info ad3531_chip = {
@@ -571,6 +689,7 @@ static const struct ad3530r_chip_info ad3531_chip = {
.num_banks = ARRAY_SIZE(ad3530r_if_config),
.num_op_mode_regs = ARRAY_SIZE(ad3531r_op_mode),
.internal_ref_support = false,
+ .configurable_ch_func = false,
};
static const struct ad3530r_chip_info ad3531r_chip = {
@@ -588,6 +707,7 @@ static const struct ad3530r_chip_info ad3531r_chip = {
.num_banks = ARRAY_SIZE(ad3530r_if_config),
.num_op_mode_regs = ARRAY_SIZE(ad3531r_op_mode),
.internal_ref_support = true,
+ .configurable_ch_func = false,
};
static const struct ad3530r_chip_info ad3532_chip = {
@@ -605,6 +725,7 @@ static const struct ad3530r_chip_info ad3532_chip = {
.num_banks = ARRAY_SIZE(ad3532r_if_config),
.num_op_mode_regs = ARRAY_SIZE(ad3532r_op_mode),
.internal_ref_support = false,
+ .configurable_ch_func = false,
};
static const struct ad3530r_chip_info ad3532r_chip = {
@@ -622,8 +743,123 @@ static const struct ad3530r_chip_info ad3532r_chip = {
.num_banks = ARRAY_SIZE(ad3532r_if_config),
.num_op_mode_regs = ARRAY_SIZE(ad3532r_op_mode),
.internal_ref_support = true,
+ .configurable_ch_func = false,
};
+static const struct ad3530r_chip_info ad5710r_chip = {
+ .name = "ad5710r",
+ .resolution = 16,
+ .regmap_config = &ad5710r_regmap_config,
+ .num_channels = ARRAY_SIZE(ad5710r_channels),
+ .sw_ldac_trig_reg = ad3530r_trigger_sw_ldac_reg,
+ .input_ch_reg = ad3530r_input_ch_reg,
+ .interface_config_a = ad3530r_if_config,
+ .output_control = ad3530r_out_ctrl,
+ .reference_control = ad3530r_ref_ctrl,
+ .op_mode = ad3530r_op_mode,
+ .num_banks = ARRAY_SIZE(ad3530r_if_config),
+ .num_op_mode_regs = ARRAY_SIZE(ad3530r_op_mode),
+ .internal_ref_support = true,
+ .configurable_ch_func = true,
+};
+
+static const struct ad3530r_chip_info ad5711r_chip = {
+ .name = "ad5711r",
+ .resolution = 12,
+ .regmap_config = &ad5710r_regmap_config,
+ .num_channels = ARRAY_SIZE(ad5710r_channels),
+ .sw_ldac_trig_reg = ad3530r_trigger_sw_ldac_reg,
+ .input_ch_reg = ad3530r_input_ch_reg,
+ .interface_config_a = ad3530r_if_config,
+ .output_control = ad3530r_out_ctrl,
+ .reference_control = ad3530r_ref_ctrl,
+ .op_mode = ad3530r_op_mode,
+ .num_banks = ARRAY_SIZE(ad3530r_if_config),
+ .num_op_mode_regs = ARRAY_SIZE(ad3530r_op_mode),
+ .internal_ref_support = true,
+ .configurable_ch_func = true,
+};
+
+static int ad3530r_parse_channel_cfg(struct iio_dev *indio_dev)
+{
+ struct ad3530r_state *st = iio_priv(indio_dev);
+ struct device *dev = regmap_get_device(st->regmap);
+ struct iio_chan_spec *channels;
+ unsigned int num_chan, i;
+ int ret;
+
+ num_chan = device_get_child_node_count(dev);
+ if (!num_chan)
+ return dev_err_probe(dev, -ENOENT, "No channels configured\n");
+
+ channels = devm_kcalloc(dev, num_chan, sizeof(*channels), GFP_KERNEL);
+ if (!channels)
+ return -ENOMEM;
+
+ i = 0;
+ device_for_each_child_node_scoped(dev, child) {
+ unsigned int mode_reg, mode_mask, ch_func;
+ enum iio_chan_type chan_type;
+ u32 reg;
+
+ ret = fwnode_property_read_u32(child, "reg", ®);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "Failed to read reg property of %pfwP\n",
+ child);
+
+ if (reg >= st->chip_info->num_channels)
+ return dev_err_probe(dev, -ECHRNG,
+ "reg out of range in %pfwP\n",
+ child);
+
+ ret = fwnode_property_read_u32(child, "adi,ch-func", &ch_func);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "Missing adi,ch-func property for %pfwP\n",
+ child);
+
+ switch (ch_func) {
+ case CH_FUNC_VOLTAGE_OUTPUT:
+ ret = regmap_set_bits(st->regmap, AD5710R_CHN_VMODE_EN,
+ AD5710R_CHN_VMODE_EN_BIT(reg));
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "Failed to set voltage output for %pfwP\n",
+ child);
+
+ chan_type = IIO_VOLTAGE;
+ break;
+ case CH_FUNC_CURRENT_OUTPUT:
+ chan_type = IIO_CURRENT;
+ break;
+ default:
+ return dev_err_probe(dev, -EINVAL,
+ "Invalid adi,ch-func %u for %pfwP\n",
+ ch_func, child);
+ }
+
+ channels[i] = ad5710r_channels[reg];
+ channels[i].type = chan_type;
+ i++;
+
+ ad5710r_get_op_mode_reg(reg, &mode_reg, &mode_mask);
+
+ /* Enable the channel in normal operation mode */
+ ret = regmap_update_bits(st->regmap, mode_reg, mode_mask,
+ field_prep(mode_mask, AD3530R_NORMAL_OP));
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "Failed to set normal operating mode for %pfwP\n",
+ child);
+ }
+
+ indio_dev->channels = channels;
+ indio_dev->num_channels = num_chan;
+
+ return 0;
+}
+
static int ad3530r_set_reg_bank_bits(const struct ad3530r_state *st,
const unsigned int *regs,
unsigned int num_regs,
@@ -656,8 +892,9 @@ static int ad3530r_write_reg_banks(const struct ad3530r_state *st,
return 0;
}
-static int ad3530r_setup(struct ad3530r_state *st, int external_vref_uV)
+static int ad3530r_setup(struct iio_dev *indio_dev, int external_vref_uV)
{
+ struct ad3530r_state *st = iio_priv(indio_dev);
const struct ad3530r_chip_info *chip_info = st->chip_info;
struct device *dev = regmap_get_device(st->regmap);
struct gpio_desc *reset_gpio;
@@ -707,19 +944,29 @@ static int ad3530r_setup(struct ad3530r_state *st, int external_vref_uV)
st->vref_mV = range_multiplier * AD3530R_INTERNAL_VREF_mV;
}
- /* Set normal operating mode for all channels */
- val = FIELD_PREP(AD3530R_OP_MODE_CHAN_MSK(0), AD3530R_NORMAL_OP) |
- FIELD_PREP(AD3530R_OP_MODE_CHAN_MSK(1), AD3530R_NORMAL_OP) |
- FIELD_PREP(AD3530R_OP_MODE_CHAN_MSK(2), AD3530R_NORMAL_OP) |
- FIELD_PREP(AD3530R_OP_MODE_CHAN_MSK(3), AD3530R_NORMAL_OP);
+ if (chip_info->configurable_ch_func) {
+ /* Channels and their operating mode are configured from DT */
+ ret = ad3530r_parse_channel_cfg(indio_dev);
+ if (ret)
+ return ret;
+ } else {
+ /* Set normal operating mode for all channels */
+ val = FIELD_PREP(AD3530R_OP_MODE_CHAN_MSK(0), AD3530R_NORMAL_OP) |
+ FIELD_PREP(AD3530R_OP_MODE_CHAN_MSK(1), AD3530R_NORMAL_OP) |
+ FIELD_PREP(AD3530R_OP_MODE_CHAN_MSK(2), AD3530R_NORMAL_OP) |
+ FIELD_PREP(AD3530R_OP_MODE_CHAN_MSK(3), AD3530R_NORMAL_OP);
- ret = ad3530r_write_reg_banks(st, st->chip_info->op_mode,
- st->chip_info->num_op_mode_regs, val);
- if (ret)
- return ret;
+ ret = ad3530r_write_reg_banks(st, chip_info->op_mode,
+ chip_info->num_op_mode_regs, val);
+ if (ret)
+ return ret;
- for (unsigned int i = 0; i < st->chip_info->num_channels; i++)
- st->chan[i].powerdown_mode = AD3530R_POWERDOWN_32K;
+ for (unsigned int i = 0; i < chip_info->num_channels; i++)
+ st->chan[i].powerdown_mode = AD3530R_POWERDOWN_32K;
+
+ indio_dev->channels = chip_info->channels;
+ indio_dev->num_channels = chip_info->num_channels;
+ }
st->ldac_gpio = devm_gpiod_get_optional(dev, "ldac", GPIOD_OUT_LOW);
if (IS_ERR(st->ldac_gpio))
@@ -777,15 +1024,13 @@ static int ad3530r_probe(struct spi_device *spi)
if (!st->chip_info->internal_ref_support && external_vref_uV == 0)
return -ENODEV;
- ret = ad3530r_setup(st, external_vref_uV);
+ ret = ad3530r_setup(indio_dev, external_vref_uV);
if (ret)
return ret;
indio_dev->name = st->chip_info->name;
indio_dev->info = &ad3530r_info;
indio_dev->modes = INDIO_DIRECT_MODE;
- indio_dev->channels = st->chip_info->channels;
- indio_dev->num_channels = st->chip_info->num_channels;
return devm_iio_device_register(&spi->dev, indio_dev);
}
@@ -797,6 +1042,8 @@ static const struct spi_device_id ad3530r_id[] = {
{ .name = "ad3531r", .driver_data = (kernel_ulong_t)&ad3531r_chip },
{ .name = "ad3532", .driver_data = (kernel_ulong_t)&ad3532_chip },
{ .name = "ad3532r", .driver_data = (kernel_ulong_t)&ad3532r_chip },
+ { .name = "ad5710r", .driver_data = (kernel_ulong_t)&ad5710r_chip },
+ { .name = "ad5711r", .driver_data = (kernel_ulong_t)&ad5711r_chip },
{ }
};
MODULE_DEVICE_TABLE(spi, ad3530r_id);
@@ -808,6 +1055,8 @@ static const struct of_device_id ad3530r_of_match[] = {
{ .compatible = "adi,ad3531r", .data = &ad3531r_chip },
{ .compatible = "adi,ad3532", .data = &ad3532_chip },
{ .compatible = "adi,ad3532r", .data = &ad3532r_chip },
+ { .compatible = "adi,ad5710r", .data = &ad5710r_chip },
+ { .compatible = "adi,ad5711r", .data = &ad5711r_chip },
{ }
};
MODULE_DEVICE_TABLE(of, ad3530r_of_match);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread