Re: [PATCH v48 6/7] arm64: dts: imx8ulp: add secure enclave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The commit message claims to add a label for `sram@2201f000`, but the patch actually adds a label to the root `sram@22010000` node and references it.
- [Low] The `memory-region` property is required by the `fsl,imx8ulp-se-ele-hsm` DT binding, but is intentionally omitted, which will trigger `dtbs_check` warnings.
--

commit 52c5da8aa6e62285f5f6a0932125a8349ec01ea0
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. It also keeps the node disabled by default and adds a
label to the SRAM node for the enclave to reference.

> Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC
> dtsi, together with a label for sram@2201f000 that the node references.

[Severity: Low]
The commit message mentions adding a label for sram@2201f000, but the diff
shows the label being added to the root sram@22010000 node instead, and then
passed to the enclave.

Is this description a typo in the commit message, or was the label intended
for a different node?

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> -	sram@22010000 {
> +	sram0: sram@22010000 {
>  		compatible = "mmio-sram";
>  		reg = <0x0 0x22010000 0x0 0x10000>;

[ ... ]

> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Low]
The fsl,imx-se.yaml binding appears to require memory-region for
fsl,imx8ulp-se-ele-hsm, and does not gate this requirement on status being
okay. 

While boards that enable the node provide the memory region, might
leaving it out here cause unwanted validation noise from dtbs_check on boards
that include imx8ulp.dtsi but leave the enclave disabled?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-imx-se-if-v48-0-dad90eec7eaf@nxp.com?part=6