Re: [PATCH v6 06/27] dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] Missing required constraint for `#reset-cells` on reset providers.
--

commit 0550a18e08e9f8b8ca4e5f412e6e70a0779197aa
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186
    
This commit regroups the MT8192 functional and system clock dt-bindings into
the MT8186 bindings to improve maintainability. It removes the MT8192-specific
binding files and adds their compatible strings to the shared MT8186 yaml
schemas.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-sys-clock.yaml
> index 199eac2034f22..41b8c61132e22 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-sys-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-sys-clock.yaml
> @@ -35,6 +35,10 @@ properties:
>            - mediatek,mt8188-infracfg-ao
>            - mediatek,mt8188-pericfg-ao
>            - mediatek,mt8188-topckgen
> +          - mediatek,mt8192-apmixedsys
> +          - mediatek,mt8192-infracfg
> +          - mediatek,mt8192-pericfg
> +          - mediatek,mt8192-topckgen

[Severity: Medium]
This is a pre-existing issue, but should the reset-cells property be
explicitly required for compatible strings that act as reset providers,
such as mediatek,mt8192-infracfg?

Currently, the properties section in mt8186-sys-clock.yaml specifies
reset-cells as an optional property globally. Since mediatek,mt8192-infracfg
functions as a reset provider, is an allOf conditional block needed to make
reset-cells explicitly required for it?

Without this constraint, an incomplete device tree node omitting reset-cells
for a reset provider will incorrectly pass schema validation silently.

>        - const: syscon
>  
>    reg:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-mt8189-clocks-system-base-v6-0-5df247f56938@collabora.com?part=6