Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vishnu Saini" <vishnu.saini@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] arm64: dts: qcom: lemans-evk: Add LVDS display overlay
Date: Sat, 05 Sep 2026 01:38:21 +0000	[thread overview]
Message-ID: <20260905013822.2B3AE1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260905-lvds-support-v3-1-b40a1b03f63c@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing Driver Support / Undocumented Compatible Strings
--

commit 78dfb1b1aa86e3fb2e9b0abac38907b8140f5130
Author: Vishnu Saini <vishnu.saini@oss.qualcomm.com>

arm64: dts: qcom: lemans-evk: Add LVDS display overlay

This commit adds a device tree overlay for the Lemans EVK IFP mezzanine to
support LVDS display output. It configures the LT9211C DSI-to-LVDS bridge and
a BOE dv215fhm-r01 panel.

> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso
> new file mode 100644
> index 0000000000000..bd3e13c46a1e7
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso
[ ... ]
> +&{/} {
> +	model = "Qualcomm Technologies, Inc. Lemans EVK LVDS";
> +
> +	panel_lvds: panel-lvds {
> +		compatible = "boe,dv215fhm-r01";

[Severity: Medium]
Will the panel_lvds node probe successfully during boot? 

The compatible string "boe,dv215fhm-r01" in
arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso appears to be
undocumented and unsupported by the panel-simple driver. Because there is no
generic fallback (such as "panel-lvds") with explicitly supplied timings, the
driver core will not find a matching OF entry and the binding will fail
deterministically.

Could a generic fallback be added, or does this compatible string need to be
added to the driver bindings first?

> +		power-supply = <&lcd_disp_bias>;
[ ... ]
> +&i2c1 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&qup_i2c1_default>;
> +
> +	status = "okay";
> +
> +	lt9211c_codec: lvds-bridge@2d {
> +		compatible = "lontium,lt9211c";

[Severity: Medium]
Is it expected that the lt9211c_codec bridge device lacks a driver match?

Similar to the panel node above, the compatible string "lontium,lt9211c" is
undocumented and not supported by the existing lontium-lt9211 driver. Without
a matching driver entry or a generic fallback like "lontium,lt9211", the
bridge will not probe, leaving the display pipeline uninitialized.

Does the lontium-lt9211 driver need to be updated to match this compatible, or
should this node include a generic fallback?

> +		reg = <0x2d>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905-lvds-support-v3-0-b40a1b03f63c@oss.qualcomm.com?part=1

  reply	other threads:[~2026-09-05  1:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05  1:30 [PATCH v3 0/3] arm64: dts: qcom: Add LVDS display overlays for lemans, monaco and rb3gen2 Vishnu Saini
2026-09-05  1:30 ` [PATCH v3 1/3] arm64: dts: qcom: lemans-evk: Add LVDS display overlay Vishnu Saini
2026-09-05  1:38   ` sashiko-bot [this message]
2026-09-05  1:30 ` [PATCH v3 2/3] arm64: dts: qcom: monaco-evk: " Vishnu Saini
2026-09-05  1:39   ` sashiko-bot
2026-09-05  1:30 ` [PATCH v3 3/3] arm64: dts: qcom: qcs6490-rb3gen2: " Vishnu Saini
2026-09-05  1:41   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260905013822.2B3AE1F00A3D@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vishnu.saini@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox