Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vishnu Saini" <vishnu.saini@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: monaco-evk: Add LVDS display overlay
Date: Sat, 05 Sep 2026 01:39:07 +0000	[thread overview]
Message-ID: <20260905013908.061881F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260905-lvds-support-v3-2-b40a1b03f63c@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing driver support and dt-binding for "boe,dv215fhm-r01" compatible string
- [Medium] Missing driver support and dt-binding for "lontium,lt9211c" compatible string
--

commit a2fe1318b3ecc93e85b9567ef46bf0dde9702054
Author: Vishnu Saini <vishnu.saini@oss.qualcomm.com>

arm64: dts: qcom: monaco-evk: Add LVDS display overlay

This commit adds a device tree overlay for the Monaco-EVK mezzanine to support
an LVDS display output. It wires up the Lontium LT9211C DSI-to-LVDS bridge
along with a BOE dual-channel 1920x1080 panel.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-lvds-boe,dv215fhm-r01.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-lvds-boe,dv215fhm-r01.dtso
> new file mode 100644
> index 0000000000000..b796df28037bf
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk-lvds-boe,dv215fhm-r01.dtso
[ ... ]
> +&{/} {
> +	model = "Qualcomm Technologies, Inc. Monaco EVK LVDS";
> +
> +	panel_lvds: panel-lvds {
> +		compatible = "boe,dv215fhm-r01";

[Severity: Medium]
Is the driver support for this panel included in another patch series? 

When this overlay is applied, the driver core will attempt to match this
compatible string against available panel drivers, but no driver currently
registers it and there is no generic fallback provided (such as panel-lvds).

This might cause the panel device to fail to probe, leaving the display
pipeline uninitialized.

[ ... ]
> +&i2c8 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&qup_i2c8_data_clk>;
> +
> +	status = "okay";
> +
> +	lt9211c_codec: lvds-bridge@2d {
> +		compatible = "lontium,lt9211c";

[Severity: Medium]
Does this compatible string have a corresponding driver binding?

The existing lontium-lt9211 driver only matches lontium,lt9211. Without 
driver support for lontium,lt9211c, the DSI-to-LVDS bridge device may fail
to match and probe, leaving the display pipeline non-functional.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905-lvds-support-v3-0-b40a1b03f63c@oss.qualcomm.com?part=2

  reply	other threads:[~2026-09-05  1:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05  1:30 [PATCH v3 0/3] arm64: dts: qcom: Add LVDS display overlays for lemans, monaco and rb3gen2 Vishnu Saini
2026-09-05  1:30 ` [PATCH v3 1/3] arm64: dts: qcom: lemans-evk: Add LVDS display overlay Vishnu Saini
2026-09-05  1:38   ` sashiko-bot
2026-09-05  1:30 ` [PATCH v3 2/3] arm64: dts: qcom: monaco-evk: " Vishnu Saini
2026-09-05  1:39   ` sashiko-bot [this message]
2026-09-05  1:30 ` [PATCH v3 3/3] arm64: dts: qcom: qcs6490-rb3gen2: " Vishnu Saini
2026-09-05  1:41   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260905013908.061881F00A3D@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vishnu.saini@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox