Re: [PATCH v2 07/10] arm64: dts: qcom: ipq6018: Flatten usb controller nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `dr_mode = "host"` property was inadvertently dropped during the flattening of the USB nodes, leaving the controller to default to OTG/device mode and breaking USB host functionality on the board.
--

commit bec8a2f8c4189aee2b01ef94a41d21f112bd2fcb
Author: George Moussalem <george.moussalem@outlook.com>

arm64: dts: qcom: ipq6018: Flatten usb controller nodes

This commit flattens the USB controller nodes in the IPQ6018 device tree and
updates them to use the latest bindings and the flattened driver approach.

> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> index a366be17c251f..9c69d3027b43f 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts

[ ... ]

> @@ -48,10 +48,6 @@ flash@0 {
>  	};
>  };
>  
> -&dwc_1 {
> -	dr_mode = "host";
> -};

[Severity: High]
Does this inadvertently drop the explicit host mode configuration for the board?

Without the dr_mode property on the new replacement node, the DWC3 core driver
defaults to OTG mode. Since the qcom,snps-dwc3 driver probes the new usb2 node
at boot without this property, this could permanently break USB functionality 
for the IPQ6018 CP01 board which is configured strictly for host operation.

Should dr_mode = "host" be added back for the new &usb2 node in this board 
file?

> -
>  &tlmm {
>  	i2c_1_pins: i2c-1-state {
>  		pins = "gpio42", "gpio43";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com?part=7