Re: [PATCH v2 10/10] arm64: dts: qcom: ipq9574: Flatten usb controller node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree Schema Violation: Incorrect ordering of `interrupt-names` for `qcom,snps-dwc3`.
--

commit 83a48e27af172a1417a53f107382ebfe032982cc
Author: George Moussalem <george.moussalem@outlook.com>

arm64: dts: qcom: ipq9574: Flatten usb controller node
    
Flatten usb controller nodes and update to using latest bindings and
flattened driver approach.

> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 5a5bda5f21a11..cf2eacb16c360 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
[ ... ]
> @@ -780,32 +777,29 @@ usb3: usb@8af8800 {
>  			assigned-clock-rates = <200000000>,
>  					       <24000000>;
>  
> -			interrupts-extended = <&intc GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
> +			interrupts-extended = <&intc GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&intc GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
>  					      <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>,
>  					      <&intc GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>,
>  					      <&intc GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
> -			interrupt-names = "pwr_event",
> +			interrupt-names = "dwc_usb3",
> +					  "pwr_event",
>  					  "qusb2_phy",
>  					  "dm_hs_phy_irq",
>  					  "dp_hs_phy_irq";

[Severity: Low]
Will this ordering cause a dtbs_check validation failure?

The qcom,snps-dwc3.yaml binding strictly requires the interrupt names for
qcom,ipq9574-dwc3 to follow an exact order: dwc_usb3, pwr_event, qusb2_phy,
dp_hs_phy_irq, and dm_hs_phy_irq.

Here in usb3: usb@8a00000, dm_hs_phy_irq appears before dp_hs_phy_irq, which
preserves the legacy ordering instead of matching the updated binding.

Could the interrupt-names and their corresponding interrupts-extended mappings
be swapped to match the schema?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com?part=10