Re: [PATCH 2/3] dtc: dt-check-style: Properly detect comments in multi-line properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Reclassifying pure comment lines inside multi-line properties as `LineType.CONTINUATION` causes them to bypass multiple style checks (line length, trailing whitespace, hex casing).
--

commit 86dbc1bb67649327675e097829b541fa2d7bd913
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Properly detect comments in multi-line properties

This commit updates the dt-check-style script to properly detect comments in
multi-line properties. It reorders the classification logic so that
continuation lines are detected before comments, preventing false positive
indentation warnings for pure comment lines within a continued property.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index eae933780c1fd..36e5b5db5e14c 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -202,6 +202,14 @@ def classify_lines(text):
>          if opens_block:
>              in_block_comment = True
>  
> +        if not prev_complete:
> +            dl = DtsLine(i, raw, LineType.CONTINUATION, depth, indent_str, code)
> +            out.append(dl)
> +            prev_complete = (code.endswith(';') or
> +                             code.endswith('{') or
> +                             code.endswith('};'))
> +            continue
> +

[Severity: Medium]
Will this change cause pure comment lines inside multi-line properties to
bypass multiple style checks like line length, trailing whitespace, and hex
casing?

By reclassifying pure comment lines inside incomplete properties as
LineType.CONTINUATION here, they are moved into dl.continuations instead of
ctx.lines.

Functions like check_hex_case(), check_line_length(), and
check_trailing_whitespace() only iterate over ctx.lines, so they will
silently skip these newly moved pure comment lines.

While there is a pre-existing flaw where regular continuation lines are
already missed by these checks, this patch actively regresses coverage for
pure comment lines by moving them into this blind spot as well. The
subsequent patch in the series does not resolve this.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906180437.166760-4-krzysztof.kozlowski@oss.qualcomm.com?part=2