Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	 devicetree@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org
Subject: Re: [PATCH 2/3] dtc: dt-check-style: Properly detect comments in multi-line properties
Date: Wed, 9 Sep 2026 09:59:10 +0200	[thread overview]
Message-ID: <20260909-juicy-handsome-wallaby-0cad87@quoll> (raw)
In-Reply-To: <20260906181533.203811F00A3A@smtp.kernel.org>

On Sun, Sep 06, 2026 at 06:15:32PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Reclassifying pure comment lines inside multi-line properties as `LineType.CONTINUATION` causes them to bypass multiple style checks (line length, trailing whitespace, hex casing).

Partially looks correct, the logic in rules (check_xxx()) should handle
continuations as well. But OTOH, mentioned above rules do not matter for
comments.

Best regards,
Krzysztof


  reply	other threads:[~2026-09-09  7:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-06 18:04 [PATCH 1/3] dtc: dt-check-style: Right strip whitespaces, leftovers before comments Krzysztof Kozlowski
2026-09-06 18:04 ` [PATCH 2/3] dtc: dt-check-style: Properly detect comments in multi-line properties Krzysztof Kozlowski
2026-09-06 18:15   ` sashiko-bot
2026-09-09  7:59     ` Krzysztof Kozlowski [this message]
2026-09-06 18:04 ` [PATCH 3/3] dtc: dt-check-style: Consistently pass same content as stripped line Krzysztof Kozlowski
2026-09-06 18:13   ` sashiko-bot
2026-09-09  8:33     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909-juicy-handsome-wallaby-0cad87@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox