* [PATCH v4 1/3] dt-bindings: soc: qcom: stats: Add compatible for Shikra
2026-09-07 13:47 [PATCH v4 0/3] Add subsystem LPM stats support for Shikra Sneh Mankad
@ 2026-09-07 13:47 ` Sneh Mankad
2026-09-13 18:10 ` Komal Bajaj
2026-09-07 13:47 ` [PATCH v4 2/3] soc: qcom: stats: Add stats compatible and config " Sneh Mankad
2026-09-07 13:47 ` [PATCH v4 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific Sneh Mankad
2 siblings, 1 reply; 7+ messages in thread
From: Sneh Mankad @ 2026-09-07 13:47 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maulik Shah
Cc: linux-arm-msm, devicetree, linux-kernel, Sneh Mankad
SoC LPM stats are present in RPM MSGRAM and subsystem LPM stats are present
in SMEM for Shikra.
A generic "qcom,rpm-stats" compatible only reads SoC LPM stats like vmin
and vlow.
Document shikra rpm compatible to read subsystem LPM stats too along with
SoC LPM stats.
Keep "qcom,rpm-stats" as a fallback for RPM targets, so that SoC level
stats are still shown even without subsystem level stats support. A plain
enum can't express that, since it caps compatible at one item. Add a oneOf
branch with items for this pattern.
Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
---
.../devicetree/bindings/soc/qcom/qcom-stats.yaml | 25 ++++++++++++++--------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml
index 686a7ef2f48af11a0e63904ff979e40d7538de65..b384a5983d43358d9fceb6fa305f20d6a0c76504 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml
@@ -18,15 +18,22 @@ description:
properties:
compatible:
- enum:
- - qcom,rpmh-stats
- - qcom,sdm845-rpmh-stats
- - qcom,rpm-stats
- # For older RPM firmware versions with fixed offset for the sleep stats
- - qcom,apq8084-rpm-stats
- - qcom,msm8226-rpm-stats
- - qcom,msm8916-rpm-stats
- - qcom,msm8974-rpm-stats
+ oneOf:
+ - enum:
+ - qcom,rpmh-stats
+ - qcom,sdm845-rpmh-stats
+ - qcom,rpm-stats
+ # For older RPM firmware versions with fixed offset for the sleep stats
+ - qcom,apq8084-rpm-stats
+ - qcom,msm8226-rpm-stats
+ - qcom,msm8916-rpm-stats
+ - qcom,msm8974-rpm-stats
+ # SoC-specific compatibles that also read subsystem-level stats,
+ # falling back to "qcom,rpm-stats" for SoC-level stats only
+ - items:
+ - enum:
+ - qcom,shikra-rpm-stats
+ - const: qcom,rpm-stats
reg:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v4 1/3] dt-bindings: soc: qcom: stats: Add compatible for Shikra
2026-09-07 13:47 ` [PATCH v4 1/3] dt-bindings: soc: qcom: stats: Add compatible " Sneh Mankad
@ 2026-09-13 18:10 ` Komal Bajaj
0 siblings, 0 replies; 7+ messages in thread
From: Komal Bajaj @ 2026-09-13 18:10 UTC (permalink / raw)
To: Sneh Mankad, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maulik Shah
Cc: linux-arm-msm, devicetree, linux-kernel
On 9/7/2026 7:17 PM, Sneh Mankad wrote:
> SoC LPM stats are present in RPM MSGRAM and subsystem LPM stats are present
> in SMEM for Shikra.
>
> A generic "qcom,rpm-stats" compatible only reads SoC LPM stats like vmin
> and vlow.
>
> Document shikra rpm compatible to read subsystem LPM stats too along with
> SoC LPM stats.
>
> Keep "qcom,rpm-stats" as a fallback for RPM targets, so that SoC level
> stats are still shown even without subsystem level stats support. A plain
> enum can't express that, since it caps compatible at one item. Add a oneOf
> branch with items for this pattern.
>
> Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Reviewed-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 2/3] soc: qcom: stats: Add stats compatible and config for Shikra
2026-09-07 13:47 [PATCH v4 0/3] Add subsystem LPM stats support for Shikra Sneh Mankad
2026-09-07 13:47 ` [PATCH v4 1/3] dt-bindings: soc: qcom: stats: Add compatible " Sneh Mankad
@ 2026-09-07 13:47 ` Sneh Mankad
2026-09-13 18:11 ` Komal Bajaj
2026-09-07 13:47 ` [PATCH v4 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific Sneh Mankad
2 siblings, 1 reply; 7+ messages in thread
From: Sneh Mankad @ 2026-09-07 13:47 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maulik Shah
Cc: linux-arm-msm, devicetree, linux-kernel, Sneh Mankad,
Konrad Dybcio, Maulik Shah
SoC LPM stats are present in RPM MSGRAM and subsystem LPM stats are
present in SMEM for Shikra.
For earlier targets using RPM processor like msm8974, rpm_master_stat.c was
used for subsystem LPM stats since those stats were populated in RPM
MSGRAM.
Here is a brief summary of previous targets and their stats configuration,
along with the drivers used to display them.
+---------------|----------------------------|---------------------------+
| SoC | subsystem LPM stats | SoC LPM stats |
|---------------|----------------------------|---------------------------|
| msm8974, | RPM processor MSGRAM | RPM processor MSGRAM |
| msm8226 | (rpm_master_stat.c) | (qcom_stats.c) |
|---------------|----------------------------|---------------------------|
| sm6350, | SMEM (DDR) | AOP processor MSGRAM |
| sdm845, etc. | (qcom_stats.c) | (qcom_stats.c) |
|---------------|----------------------------|---------------------------|
| Shikra | SMEM (DDR) | RPM processor MSGRAM |
| | (qcom_stats.c) | (qcom_stats.c) |
+---------------|----------------------------|---------------------------+
qcom_stats.c supports both the configurations for shikra, reading subsystem
LPM stats from SMEM and reading SoC LPM stats from RPM MSGRAM.
A generic "qcom,rpm-stats" compatible only reads SoC LPM stats like vmin
and vlow. Add shikra rpm compatible and config to read subsystem LPM
stats too along with SoC LPM stats.
Below is an example showing LPM stats for "apss" subsystem with this
change:
cat /sys/kernel/debug/qcom_stats/apss
Count: 2192
Last Entered At: 5498618336
Last Exited At: 5498708046
Accumulated Duration: 2046572620.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
---
drivers/soc/qcom/qcom_stats.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
index 2e380faf9080354fae120e74f0b9bd1f3786d3e5..2f1615e583bbc6ea596d8b73d9bb0a2a00953cfb 100644
--- a/drivers/soc/qcom/qcom_stats.c
+++ b/drivers/soc/qcom/qcom_stats.c
@@ -376,6 +376,14 @@ static const struct stats_config rpm_data_dba0 = {
.subsystem_stats_in_smem = false,
};
+static const struct stats_config rpm_data_shikra = {
+ .stats_offset = 0,
+ .num_records = 2,
+ .appended_stats_avail = true,
+ .dynamic_offset = true,
+ .subsystem_stats_in_smem = true,
+};
+
static const struct stats_config rpmh_data_sdm845 = {
.stats_offset = 0x48,
.num_records = 2,
@@ -401,6 +409,7 @@ static const struct of_device_id qcom_stats_table[] = {
{ .compatible = "qcom,rpm-stats", .data = &rpm_data },
{ .compatible = "qcom,rpmh-stats", .data = &rpmh_data },
{ .compatible = "qcom,sdm845-rpmh-stats", .data = &rpmh_data_sdm845 },
+ { .compatible = "qcom,shikra-rpm-stats", .data = &rpm_data_shikra },
{ }
};
MODULE_DEVICE_TABLE(of, qcom_stats_table);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v4 2/3] soc: qcom: stats: Add stats compatible and config for Shikra
2026-09-07 13:47 ` [PATCH v4 2/3] soc: qcom: stats: Add stats compatible and config " Sneh Mankad
@ 2026-09-13 18:11 ` Komal Bajaj
0 siblings, 0 replies; 7+ messages in thread
From: Komal Bajaj @ 2026-09-13 18:11 UTC (permalink / raw)
To: Sneh Mankad, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maulik Shah
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Maulik Shah
On 9/7/2026 7:17 PM, Sneh Mankad wrote:
> SoC LPM stats are present in RPM MSGRAM and subsystem LPM stats are
> present in SMEM for Shikra.
>
> For earlier targets using RPM processor like msm8974, rpm_master_stat.c was
> used for subsystem LPM stats since those stats were populated in RPM
> MSGRAM.
>
> Here is a brief summary of previous targets and their stats configuration,
> along with the drivers used to display them.
>
> +---------------|----------------------------|---------------------------+
> | SoC | subsystem LPM stats | SoC LPM stats |
> |---------------|----------------------------|---------------------------|
> | msm8974, | RPM processor MSGRAM | RPM processor MSGRAM |
> | msm8226 | (rpm_master_stat.c) | (qcom_stats.c) |
> |---------------|----------------------------|---------------------------|
> | sm6350, | SMEM (DDR) | AOP processor MSGRAM |
> | sdm845, etc. | (qcom_stats.c) | (qcom_stats.c) |
> |---------------|----------------------------|---------------------------|
> | Shikra | SMEM (DDR) | RPM processor MSGRAM |
> | | (qcom_stats.c) | (qcom_stats.c) |
> +---------------|----------------------------|---------------------------+
>
> qcom_stats.c supports both the configurations for shikra, reading subsystem
> LPM stats from SMEM and reading SoC LPM stats from RPM MSGRAM.
>
> A generic "qcom,rpm-stats" compatible only reads SoC LPM stats like vmin
> and vlow. Add shikra rpm compatible and config to read subsystem LPM
> stats too along with SoC LPM stats.
>
> Below is an example showing LPM stats for "apss" subsystem with this
> change:
>
> cat /sys/kernel/debug/qcom_stats/apss
> Count: 2192
> Last Entered At: 5498618336
> Last Exited At: 5498708046
> Accumulated Duration: 2046572620.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Reviewed-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Reviewed-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific
2026-09-07 13:47 [PATCH v4 0/3] Add subsystem LPM stats support for Shikra Sneh Mankad
2026-09-07 13:47 ` [PATCH v4 1/3] dt-bindings: soc: qcom: stats: Add compatible " Sneh Mankad
2026-09-07 13:47 ` [PATCH v4 2/3] soc: qcom: stats: Add stats compatible and config " Sneh Mankad
@ 2026-09-07 13:47 ` Sneh Mankad
2026-09-13 18:11 ` Komal Bajaj
2 siblings, 1 reply; 7+ messages in thread
From: Sneh Mankad @ 2026-09-07 13:47 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maulik Shah
Cc: linux-arm-msm, devicetree, linux-kernel, Sneh Mankad,
Konrad Dybcio
A generic "qcom,rpm-stats" compatible only reads stats for SoC level LPM
stats like vmin and vlow.
Shikra SoC specific compatible allows reading individual subsystem level
LPM stats along with SoC level LPM stats. Change it.
Keep "qcom,rpm-stats" as fallback compatible.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/shikra.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
index 4e5bc9e17c8ed8914733ac9fdc9b69128b40216e..b299f316e3c61858c4b380f6211d0f36ef9fecf9 100644
--- a/arch/arm64/boot/dts/qcom/shikra.dtsi
+++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
@@ -535,7 +535,7 @@ apss_mpm: sram@1b8 {
};
sram@4690000 {
- compatible = "qcom,rpm-stats";
+ compatible = "qcom,shikra-rpm-stats", "qcom,rpm-stats";
reg = <0x0 0x04690000 0x0 0x14000>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v4 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific
2026-09-07 13:47 ` [PATCH v4 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific Sneh Mankad
@ 2026-09-13 18:11 ` Komal Bajaj
0 siblings, 0 replies; 7+ messages in thread
From: Komal Bajaj @ 2026-09-13 18:11 UTC (permalink / raw)
To: Sneh Mankad, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maulik Shah
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio
On 9/7/2026 7:17 PM, Sneh Mankad wrote:
> A generic "qcom,rpm-stats" compatible only reads stats for SoC level LPM
> stats like vmin and vlow.
>
> Shikra SoC specific compatible allows reading individual subsystem level
> LPM stats along with SoC level LPM stats. Change it.
>
> Keep "qcom,rpm-stats" as fallback compatible.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Reviewed-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread