Re: [PATCH v5 08/10] ASoC: qcom: Add QAIF IRQ handling, suspend/resume and platform register

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Hardcoded 2 cells for 'iommus' property parsing ignores '#iommu-cells' specification.
--

commit c9879e803b7f932397e4e9a7c40595da90b01510
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: qcom: Add QAIF IRQ handling, suspend/resume and platform register

This commit completes the QAIF PCM platform support by adding component
registration and trigger handling for DMA interrupts. It sets up IRQ
dispatching for AIF and CIF DMA handlers, manages stream starting/stopping,
and retrieves the IOMMU stream ID during probe.

> diff --git a/sound/soc/qcom/qaif-platform.c b/sound/soc/qcom/qaif-platform.c
> index a64bbd7f6fe56..1da50a834b786 100644
> --- a/sound/soc/qcom/qaif-platform.c
> +++ b/sound/soc/qcom/qaif-platform.c

[ ... ]

> +int asoc_qcom_qaif_platform_register(struct platform_device *pdev)
> +{
> +	struct qaif_drv_data *drvdata = platform_get_drvdata(pdev);
> +	struct of_phandle_args iommu_spec;
> +	u32 sid;
> +	int ret;
> +
> +	if (!drvdata->variant->alloc_stream_dma_idx ||
> +	    !drvdata->variant->free_stream_dma_idx)
> +		return dev_err_probe(&pdev->dev, -EINVAL,
> +				     "Variant missing mandatory callbacks\n");
> +
> +	ret = of_parse_phandle_with_fixed_args(pdev->dev.of_node,
> +					       "iommus", 2, 0,
> +					       &iommu_spec);

[Severity: High]
Is it safe to hardcode 2 cells for the "iommus" property here?

This will deterministically fail to probe on platforms where the target
IOMMU uses #iommu-cells = <1>, which is very common for ARM SMMUs passing
a single Stream ID.

Should this use of_parse_phandle_with_args(pdev->dev.of_node, "iommus",
"#iommu-cells", 0, &iommu_spec) instead to correctly determine the cell
count from the target IOMMU node?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-b4-qaif-shikra-audio-v5-0-6d8ad9ba5c9f@oss.qualcomm.com?part=8