Re: [PATCH v5 09/10] ASoC: qcom: Add Shikra QAIF support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Redundant devm_clk_get() calls for the same clock index leak devres memory and keep unnecessary clock references.
--

commit 63cae5b8a9cf9b494a9486e0a0b07d1b244a6f6c
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: qcom: Add Shikra QAIF support

This commit adds the Shikra variant data for the Qualcomm Audio Interface
(QAIF) driver. It provides DMA-to-DAI mappings, clock names, DAI driver
data, and other parameters needed by the QAIF driver.

> diff --git a/sound/soc/qcom/qaif-shikra.c b/sound/soc/qcom/qaif-shikra.c
> new file mode 100644
> index 0000000000000..0d5c2baade28f
> --- /dev/null
> +++ b/sound/soc/qcom/qaif-shikra.c

[ ... ]

> +static const struct qaif_variant shikra_qaif_data = {

[ ... ]

> +	.num_clks		= 3,
> +
> +	.dai_driver		= shikra_qaif_cpu_dai_driver,
> +	.num_dai		= ARRAY_SIZE(shikra_qaif_cpu_dai_driver),
> +
> +	.dai_bit_clk_names	= (const char * const []) {
> +					"aif_if0_ibit",
> +					"aif_if1_ibit",
> +					"aif_if2_ibit",
> +					"aif_if3_ibit",
> +				},

[Severity: Medium]
Will this configuration cause redundant devm_clk_get() calls and leak devres
memory?

Looking at asoc_qcom_qaif_cpu_platform_probe() in sound/soc/qcom/qaif-cpu.c, it
iterates over variant->num_dai and fetches the clock for each DAI's index:

	for (i = 0; i < variant->num_dai; i++) {
		...
		idx = variant->get_dma_idx(dai_id);
		if (idx < 0)
			continue;

		drvdata->mi2s_bit_clk[idx] =
			devm_clk_get(dev, variant->dai_bit_clk_names[idx]);
		...
	}

Since multiple DAIs in shikra_qaif_cpu_dai_driver (such as AIF_MI2S_RX_0 and
AIF_MI2S_TX_0) map to the same get_dma_idx() value, won't this overwrite the
same drvdata->mi2s_bit_clk[idx] pointer multiple times without checking if it
was already acquired?

Could this allocate redundant devres handles and keep unnecessary clock
references during probe?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-b4-qaif-shikra-audio-v5-0-6d8ad9ba5c9f@oss.qualcomm.com?part=9