Re: [PATCH 3/3] arm64: dts: broadcom: Add RTC to Raspberry Pi 5 B

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The RTC node uses a non-generic node name.
- [Low] Commit message contains multiple obvious spelling mistakes.
--

commit badbff5dbc66bc9afed161f21071dd3b6408304c
Author: Sander Speetjens <sander.speetjens@gmail.com>

arm64: dts: broadcom: Add RTC to Raspberry Pi 5 B

This commit adds a devicetree node for the battery-backed RTC found on the
Raspberry Pi 5's custom DA9091 PMIC, accessed via the firmware mailbox.

> The Raspberry Pi 5 contains a RTC on a custom DA9091 PMIC that is accesed trought the firware mailbox.
> This so we have a battery backed RTC, so the OS does not need network to get the time.

[Severity: Low]
There are a few typos here: "accesed trought the firware" should be "accessed
through the firmware", and "This so we have" should be "This is so we have".

> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
> index b7a6bc34ae1ab..5a82dd585f32b 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
> @@ -102,6 +102,13 @@ wl_on_reg: wl-on-reg {
>  		startup-delay-us = <150000>;
>  		enable-active-high;
>  	};
> +
> +	rpi_rtc: rpi-rtc {

[Severity: Low]
Should this node use a generic name like "rtc" instead of "rpi-rtc"? The
Devicetree specification recommends generic names reflecting the class of the
device rather than the specific model.

> +		compatible = "raspberrypi,rpi-rtc";
> +		firmware = <&firmware>;
> +		status = "okay";
> +		trickle-charge-microvolt = <0>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909141300.1368790-1-sander.speetjens@gmail.com?part=3