From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sander Speetjens <sander.speetjens@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Jonathan Bell <jonathan@raspberrypi.com>,
Stefan Wahren <wahrenst@gmx.net>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: rtc: Add Raspberry Pi 5 RTC binding
Date: Wed, 9 Sep 2026 17:54:32 +0200 [thread overview]
Message-ID: <8cd19ae8-372b-444b-bd2a-dc01221b5896@kernel.org> (raw)
In-Reply-To: <4c237cd8-024f-405e-a00e-e22ff9529d08@kernel.org>
On 09/09/2026 17:47, Krzysztof Kozlowski wrote:
> On 09/09/2026 16:12, Sander Speetjens wrote:
>> +
>> + firmware:
>
> There is no such generic property. You need vendor prefix. Wasn't this
> already discussed for Rpi? I feel like every time contributors send
> downstream DTS ignoring what was discussed upstream.
>
>
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle to the Raspberry Pi firmware device.
>
> You said nothing more than property name and type. Explain what for.
>
And more important, where is any interface to actually control the RTC?
I see nothing, so your firmware is? Then this is not a separate device
and you just added DTS for your driver, which is a no go (see writing
bindings).
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-09 15:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 14:12 [PATCH 0/3] Raspberry Pi 5 RTC driver Sander Speetjens
2026-09-09 14:12 ` [PATCH 1/3] dt-bindings: rtc: Add Raspberry Pi 5 RTC binding Sander Speetjens
2026-09-09 14:23 ` sashiko-bot
2026-09-09 15:15 ` Alexandre Belloni
2026-09-09 15:47 ` Krzysztof Kozlowski
2026-09-09 15:54 ` Krzysztof Kozlowski [this message]
2026-09-09 20:38 ` Sander Speetjens
[not found] ` <CAAOJLPHNGgC7B=7ESCifZ1FPcR6V=Hcg-q-aaVg_9M_-d6Fh2A@mail.gmail.com>
2026-09-10 7:08 ` Krzysztof Kozlowski
2026-09-10 8:10 ` Sander Speetjens
2026-09-10 16:33 ` Stefan Wahren
2026-09-09 14:12 ` [PATCH 2/3] rtc: Add Raspberry Pi 5 RTC driver Sander Speetjens
2026-09-09 14:34 ` sashiko-bot
2026-09-09 15:20 ` Alexandre Belloni
2026-09-09 15:22 ` Alexandre Belloni
2026-09-09 15:44 ` Krzysztof Kozlowski
2026-09-09 14:13 ` [PATCH 3/3] arm64: dts: broadcom: Add RTC to Raspberry Pi 5 B Sander Speetjens
2026-09-09 14:44 ` sashiko-bot
2026-09-09 15:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cd19ae8-372b-444b-bd2a-dc01221b5896@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=jonathan@raspberrypi.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sander.speetjens@gmail.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox