Re: [PATCH v5 09/10] dt-bindings: iio: dac: add support for MCP48FEB02 SPI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing definitions for `spi-cpha` and `spi-cpol` in the top-level `properties` block causes schema validation to reject valid device trees.
--

commit a76968b0d8e0b0cd896879ce5f6827e2fd5d9f18
Author: Ariana Lazar <ariana.lazar@microchip.com>

dt-bindings: iio: dac: add support for MCP48FEB02 SPI

This commit adds support for the SPI MCP48FxBy1/2/4/8 part numbers, introduces
the spi-max-frequency property, adds SPI-specific schema validation conditions,
and provides a devicetree example for SPI usage.

> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> index d131f136bd151..a86d094f0d4b5 100644
> --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml

[ ... ]

>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            pattern: "^microchip,mcp48f[ev]b[0-2][1248]$"
> +    then:
> +      $ref: /schemas/spi/spi-peripheral-props.yaml#
> +      dependencies:
> +        spi-cpha: [ spi-cpol ]
> +        spi-cpol: [ spi-cpha ]

[Severity: Medium]
Will device trees configuring the SPI clock phase and polarity for this device
incorrectly fail dt-schema validation? 

This dependencies block within the allOf conditional intends to allow and 
enforce co-occurrence of the properties, but spi-cpha and spi-cpol are 
missing from the top-level properties block.

> +    else:
> +      properties:
> +        spi-max-frequency: false
> +        spi-cpha: false
> +        spi-cpol: false

[ ... ]

> @@ -272,7 +372,7 @@ allOf:
>        properties:
>          microchip,vref1-buffered: false
>  
> -additionalProperties: false
> +unevaluatedProperties: false

[Severity: Medium]
Because unevaluatedProperties is strictly false here, and spi-cpha and
spi-cpol are omitted from the top-level properties block, won't any valid
device tree using these properties trigger a validation error during
dtbs_check?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-mcp47feb02_refactor-v5-0-8b67bcab93d1@microchip.com?part=9