From: sashiko-bot@kernel.org
To: "Jan Paszkowski" <jan.m.paszkowski@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS
Date: Wed, 09 Sep 2026 17:30:31 +0000 [thread overview]
Message-ID: <20260909173032.240941F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260909172421.33593-2-jan.m.paszkowski@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Duplicate Device Tree property `vcc-max-microamp` overwrites the intended value and leaves `vccq-max-microamp` unconfigured.
--
commit c3bcdc386d74df860f7d4d12d1aed983ad46ea5d
Author: Jan Paszkowski <jan.m.paszkowski@gmail.com>
arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS
This commit enables UFS on the sm8350-sony-xperia-sagami device, noting
that previous device-killing bugs seem to be resolved.
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> index 4b62ee50da7be..969c8cb31df9f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> @@ -893,9 +893,20 @@ sdc2_card_det_sleep: sd-card-det-sleep-state {
[ ... ]
> -/* BIG WARNING! DO NOT TOUCH UFS, YOUR DEVICE WILL DIE! */
> -&ufs_mem_hc { status = "disabled"; };
> -&ufs_mem_phy { status = "disabled"; };
> +&ufs_mem_hc {
> + status = "okay";
> + reset-gpios = <&tlmm 203 GPIO_ACTIVE_LOW>;
> + vcc-supply = <&pm8350_l7>;
> + vcc-max-microamp = <800000>;
> + vccq-supply = <&pm8350_l9>;
> + vcc-max-microamp = <900000>;
[Severity: High]
Does this mistakenly define vcc-max-microamp twice instead of configuring
vccq-max-microamp for the pm8350_l9 supply?
Because the property name is duplicated, the device tree compiler will
overwrite the initial 800,000 uA value with 900,000 uA, leaving the vccq
regulator without its intended maximum microamp constraint.
Given the history of UFS hardware issues mentioned in the commit message,
could this unconfigured vccq regulator lead to system instability, boot
failures, or hardware damage?
> +};
> +
> +&ufs_mem_phy {
> + status = "okay";
> + vdda-phy-supply = <&pm8350_l5>;
> + vdda-pll-supply = <&pm8350_l6>;
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909172421.33593-2-jan.m.paszkowski@gmail.com?part=1
next prev parent reply other threads:[~2026-09-09 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 17:13 [PATCH 0/1] arm64: dts: qcom: sm8350-sagami: UFS Jan Paszkowski
2026-09-09 17:13 ` [PATCH 1/1] arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS Jan Paszkowski
2026-09-09 17:30 ` sashiko-bot [this message]
2026-09-09 17:44 ` Jan Paszkowski
2026-09-09 19:07 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909173032.240941F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jan.m.paszkowski@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox