Re: [PATCH 1/1] arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS

["Jan Paszkowski" <jan.m.paszkowski@gmail.com>]

On Wed Sep 9, 2026 at 7:30 PM CEST, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] Duplicate Device Tree property `vcc-max-microamp` overwrites the intended value and leaves `vccq-max-microamp` unconfigured.
> --
>
> commit c3bcdc386d74df860f7d4d12d1aed983ad46ea5d
> Author: Jan Paszkowski <jan.m.paszkowski@gmail.com>
>
> arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS
>
> This commit enables UFS on the sm8350-sony-xperia-sagami device, noting
> that previous device-killing bugs seem to be resolved.
>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
>> index 4b62ee50da7be..969c8cb31df9f 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
>> @@ -893,9 +893,20 @@ sdc2_card_det_sleep: sd-card-det-sleep-state {
>
> [ ... ]
>
>> -/* BIG WARNING! DO NOT TOUCH UFS, YOUR DEVICE WILL DIE! */
>> -&ufs_mem_hc { status = "disabled"; };
>> -&ufs_mem_phy { status = "disabled"; };
>> +&ufs_mem_hc {
>> +	status = "okay";
>> +	reset-gpios = <&tlmm 203 GPIO_ACTIVE_LOW>;
>> +	vcc-supply = <&pm8350_l7>;
>> +	vcc-max-microamp = <800000>;
>> +	vccq-supply = <&pm8350_l9>;
>> +	vcc-max-microamp = <900000>;
>
> [Severity: High]
> Does this mistakenly define vcc-max-microamp twice instead of configuring
> vccq-max-microamp for the pm8350_l9 supply?
>
> Because the property name is duplicated, the device tree compiler will
> overwrite the initial 800,000 uA value with 900,000 uA, leaving the vccq
> regulator without its intended maximum microamp constraint. 
>
> Given the history of UFS hardware issues mentioned in the commit message,
> could this unconfigured vccq regulator lead to system instability, boot
> failures, or hardware damage?
>
Yes, this is a typo in the sent patch. The patch I tested had
vccq-max-microamp here. Sorry for that.
>> +};
>> +
>> +&ufs_mem_phy {
>> +	status = "okay";
>> +	vdda-phy-supply = <&pm8350_l5>;
>> +	vdda-pll-supply = <&pm8350_l6>;
>> +};