[PATCH 0/1] arm64: dts: qcom: sm8350-sagami: UFS

[PATCH 0/1] arm64: dts: qcom: sm8350-sagami: UFS

[Jan Paszkowski]

This patch is about turning on the UFS for the sony xperia sagami
platform.

The patch is small, but due to the grave risk of the patch combined with
my inexperience I wanted to write this cover letter.

While digging through the reasons for the UFS bug in sony devices, I
stumbled upon a downstream workaround in the initial commit for
sm8250-sony-xperia devices [1]. The workaround did not mention the
sagami platform. Looking through android patches for UFS for the sony
sagami copyleft kernel, they seemed to be minor compared to previous
generations[2].

With that I got a spare pdx215 to try this on. I compiled a kernel with
postmarketOS tools. Normal flashing of pmOS on a single partition seemed
to not work, though the UFS device was visible when booting on the sd
card. That said both split flashing of pmOS onto two partitions and
formating partitions worked, at least for super and userdata with ext4.
The booted device detected the partitions and even worked without the sd
card. With that I wanted to send it to the mailing lists in case the bug
is gone this generation.

I guess that most likely I am missing something. If so please respond to
this series. I am happy to test  further to make sure it won't brick
anybody's device.

[1] https://github.com/kholk/kernel/commit/2e7a9ee1c91a016baa0b826a7752ec45663a0561
[2] https://github.com/sonyxperiadev/kernel-copyleft/tree/61.0.A.11.xxx


Jan Paszkowski (1):
  arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS

 .../dts/qcom/sm8350-sony-xperia-sagami.dtsi     | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

-- 
2.55.0

[PATCH 1/1] arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS

[Jan Paszkowski]

The UFS bug that haunted the Sony devices seems to be gone this
generation. This patch enables it for the ability to use internal
storage.

Signed-off-by: Jan Paszkowski <jan.m.paszkowski@gmail.com>
---
 .../dts/qcom/sm8350-sony-xperia-sagami.dtsi     | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
index 4b62ee50da7b..969c8cb31df9 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
@@ -893,9 +893,20 @@ sdc2_card_det_sleep: sd-card-det-sleep-state {
 	};
 };
 
-/* BIG WARNING! DO NOT TOUCH UFS, YOUR DEVICE WILL DIE! */
-&ufs_mem_hc { status = "disabled"; };
-&ufs_mem_phy { status = "disabled"; };
+&ufs_mem_hc {
+	status = "okay";
+	reset-gpios = <&tlmm 203 GPIO_ACTIVE_LOW>;
+	vcc-supply = <&pm8350_l7>;
+	vcc-max-microamp = <800000>;
+	vccq-supply = <&pm8350_l9>;
+	vcc-max-microamp = <900000>;
+};
+
+&ufs_mem_phy {
+	status = "okay";
+	vdda-phy-supply = <&pm8350_l5>;
+	vdda-pll-supply = <&pm8350_l6>;
+};
 
 &usb_1 {
 	status = "okay";
-- 
2.55.0

Re: [PATCH 1/1] arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Duplicate Device Tree property `vcc-max-microamp` overwrites the intended value and leaves `vccq-max-microamp` unconfigured.
--

commit c3bcdc386d74df860f7d4d12d1aed983ad46ea5d
Author: Jan Paszkowski <jan.m.paszkowski@gmail.com>

arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS

This commit enables UFS on the sm8350-sony-xperia-sagami device, noting
that previous device-killing bugs seem to be resolved.

> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> index 4b62ee50da7be..969c8cb31df9f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> @@ -893,9 +893,20 @@ sdc2_card_det_sleep: sd-card-det-sleep-state {

[ ... ]

> -/* BIG WARNING! DO NOT TOUCH UFS, YOUR DEVICE WILL DIE! */
> -&ufs_mem_hc { status = "disabled"; };
> -&ufs_mem_phy { status = "disabled"; };
> +&ufs_mem_hc {
> +	status = "okay";
> +	reset-gpios = <&tlmm 203 GPIO_ACTIVE_LOW>;
> +	vcc-supply = <&pm8350_l7>;
> +	vcc-max-microamp = <800000>;
> +	vccq-supply = <&pm8350_l9>;
> +	vcc-max-microamp = <900000>;

[Severity: High]
Does this mistakenly define vcc-max-microamp twice instead of configuring
vccq-max-microamp for the pm8350_l9 supply?

Because the property name is duplicated, the device tree compiler will
overwrite the initial 800,000 uA value with 900,000 uA, leaving the vccq
regulator without its intended maximum microamp constraint. 

Given the history of UFS hardware issues mentioned in the commit message,
could this unconfigured vccq regulator lead to system instability, boot
failures, or hardware damage?

> +};
> +
> +&ufs_mem_phy {
> +	status = "okay";
> +	vdda-phy-supply = <&pm8350_l5>;
> +	vdda-pll-supply = <&pm8350_l6>;
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909172421.33593-2-jan.m.paszkowski@gmail.com?part=1

Re: [PATCH 1/1] arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS

[Jan Paszkowski]

On Wed Sep 9, 2026 at 7:30 PM CEST, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] Duplicate Device Tree property `vcc-max-microamp` overwrites the intended value and leaves `vccq-max-microamp` unconfigured.
> --
>
> commit c3bcdc386d74df860f7d4d12d1aed983ad46ea5d
> Author: Jan Paszkowski <jan.m.paszkowski@gmail.com>
>
> arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS
>
> This commit enables UFS on the sm8350-sony-xperia-sagami device, noting
> that previous device-killing bugs seem to be resolved.
>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
>> index 4b62ee50da7be..969c8cb31df9f 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
>> @@ -893,9 +893,20 @@ sdc2_card_det_sleep: sd-card-det-sleep-state {
>
> [ ... ]
>
>> -/* BIG WARNING! DO NOT TOUCH UFS, YOUR DEVICE WILL DIE! */
>> -&ufs_mem_hc { status = "disabled"; };
>> -&ufs_mem_phy { status = "disabled"; };
>> +&ufs_mem_hc {
>> +	status = "okay";
>> +	reset-gpios = <&tlmm 203 GPIO_ACTIVE_LOW>;
>> +	vcc-supply = <&pm8350_l7>;
>> +	vcc-max-microamp = <800000>;
>> +	vccq-supply = <&pm8350_l9>;
>> +	vcc-max-microamp = <900000>;
>
> [Severity: High]
> Does this mistakenly define vcc-max-microamp twice instead of configuring
> vccq-max-microamp for the pm8350_l9 supply?
>
> Because the property name is duplicated, the device tree compiler will
> overwrite the initial 800,000 uA value with 900,000 uA, leaving the vccq
> regulator without its intended maximum microamp constraint. 
>
> Given the history of UFS hardware issues mentioned in the commit message,
> could this unconfigured vccq regulator lead to system instability, boot
> failures, or hardware damage?
>
Yes, this is a typo in the sent patch. The patch I tested had
vccq-max-microamp here. Sorry for that.
>> +};
>> +
>> +&ufs_mem_phy {
>> +	status = "okay";
>> +	vdda-phy-supply = <&pm8350_l5>;
>> +	vdda-pll-supply = <&pm8350_l6>;
>> +};

Re: [PATCH 1/1] arm64: dts: qcom: sm8350-sony-xperia-sagami: enable UFS

[Dmitry Baryshkov]

On Wed, Sep 09, 2026 at 07:13:12PM +0200, Jan Paszkowski wrote:
> The UFS bug that haunted the Sony devices seems to be gone this
> generation. This patch enables it for the ability to use internal
> storage.
> 
> Signed-off-by: Jan Paszkowski <jan.m.paszkowski@gmail.com>
> ---
>  .../dts/qcom/sm8350-sony-xperia-sagami.dtsi     | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> index 4b62ee50da7b..969c8cb31df9 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> @@ -893,9 +893,20 @@ sdc2_card_det_sleep: sd-card-det-sleep-state {
>  	};
>  };
>  
> -/* BIG WARNING! DO NOT TOUCH UFS, YOUR DEVICE WILL DIE! */

You were brave.


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>



-- 
With best wishes
Dmitry