Re: [PATCH v4 1/2] dt-bindings: hwmon: pmbus: Add Infineon tda38740 and tda38725

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding omits standard properties for voltage regulators and PMBus alerts, preventing complete hardware description due to `additionalProperties: false`.
--

commit ad3970039034a68048f73bbed304c8a0650c3bdf
Author: Colin Huang <u8813345@gmail.com>

dt-bindings: hwmon: pmbus: Add Infineon tda38740 and tda38725

This commit adds device tree binding documentation for the Infineon
TDA38740 and TDA38725 PMBus synchronous buck regulators.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

[Severity: Medium]
Because this is a voltage regulator with a PMBus interface, board device
trees might need to describe physical hardware connections like the SMBALERT#
interrupt pin or standard regulator supply nodes.

Will this strict constraint cause dt-schema validation failures if a board
node attempts to add standard properties like interrupts?

Should this schema include standard regulator and interrupt properties in
the definition, or perhaps use unevaluatedProperties with the relevant
$ref inclusions, to allow boards to completely describe their hardware
without validation errors?

> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-add-tda38740-and-tda38725-v4-0-dbae7fabce09@gmail.com?part=1