Re: [PATCH v4 2/2] hwmon: (pmbus/tda38740) Add driver for Infineon TDA38740/TDA38725

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `struct tda38740_data` is used and allocated in `tda38740_probe()` but is never defined, causing a compilation error.
--

commit 38416ec86775dd4db25c806a9c1584cb372a401b
Author: Colin Huang <u8813345@gmail.com>

hwmon: (pmbus/tda38740) Add driver for Infineon TDA38740/TDA38725

This commit adds a new PMBus driver for Infineon TDA38740 and TDA38725
single-voltage synchronous buck regulators. It provides standard PMBus
hardware monitoring telemetry.

> diff --git a/drivers/hwmon/pmbus/tda38740.c b/drivers/hwmon/pmbus/tda38740.c
> new file mode 100644
> index 0000000000000..6d3e9884f733b
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/tda38740.c
[ ... ]
> +static int tda38740_probe(struct i2c_client *client)
> +{
> +	struct tda38740_data *data;
> +
> +	data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);

[Severity: Low]
Is struct tda38740_data missing its definition?

It appears this struct is never defined in this file or included headers.
Does this result in a compilation error here, since sizeof() cannot evaluate
an incomplete type?

> +	if (!data)
> +		return -ENOMEM;
> +
> +	memcpy(&data->info, &tda38740_info, sizeof(tda38740_info));

[Severity: Low]
Because the type is incomplete, does dereferencing data->info here also
cause a build failure? Would it be better to define the struct locally
with the info member, or directly allocate a struct pmbus_driver_info
instead?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-add-tda38740-and-tda38725-v4-0-dbae7fabce09@gmail.com?part=2