Re: [PATCH v2 5/8] arm64: dts: rockchip: Rename rk3399 HDMI audio card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] ALSA card rename causes userspace ABI breakage
--

commit d2106b3a23ffdceb3724e809b448fcb65bba2229
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3399 HDMI audio card

This commit renames the hdmi-sound ALSA card to "RK3399 HDMI" in the rk3399
base device tree to better match naming conventions.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> index 49c68fe65de66..c46e58d4af0d4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> @@ -2008,7 +2008,7 @@ hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <256>;
> -		simple-audio-card,name = "hdmi-sound";
> +		simple-audio-card,name = "RK3399 HDMI";

[Severity: Critical]
Does renaming the ALSA card cause a userspace ABI regression?

The simple-audio-card,name property defines the ALSA card name exposed to
userspace (e.g., in /proc/asound/cards and sysfs). Userspace audio services
like PulseAudio, PipeWire, ALSA Use Case Manager (UCM), and ALSA state
restoration (alsactl) rely on this exact string to identify the hardware,
load correct routing profiles, and restore saved volume levels.

Renaming it from hdmi-sound to RK3399 HDMI might break this ABI, leading to
broken audio configurations or lost mixer states on kernel upgrade without
proper deprecation.

>  		status = "disabled";
>  
>  		simple-audio-card,cpu {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-fix-rockchip-hdmi-audio-names-v2-0-1396a6168e20@collabora.com?part=5