Re: [PATCH v2 6/8] arm64: dts: rockchip: Rename rk3566 and rk3568 HDMI audio cards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Critical] ALSA sound card name change breaks ABI / backwards compatibility with existing userspace configurations.
- [Low] Missing semicolon at the end of the `&hdmi_sound` node overrides causes a Device Tree Compiler (DTC) syntax error, breaking the build.
--

commit 544b3c713c02b4d695c704bc8f12f60bc89bcc82
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3566 and rk3568 HDMI audio cards

This patch moves the HDMI audio card name for RK3566 and RK3568 into
their respective dtsi files. It updates the card name to match the SoC,
preventing collisions with the generic HDMI string used by other SoCs.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-base.dtsi
> index e56e0b6ba9411..0086ff49fee23 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-base.dtsi
> @@ -6,6 +6,10 @@ / {
>  	compatible = "rockchip,rk3566";
>  };
>  
> +&hdmi_sound {
> +	simple-audio-card,name = "RK3566 HDMI";
> +}

[Severity: Low]
Does this missing semicolon cause a Device Tree Compiler (DTC) syntax error?

DTC strictly requires a semicolon after the closing brace of node overrides
at the root level.

Without it, a build failure occurs when dtc encounters the next node token
(&pipegrf) in rk3566-base.dtsi.

> +
>  &pipegrf {
>  	compatible = "rockchip,rk3566-pipe-grf", "syscon";
>  };

[ ... ]

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index 3bc653f027f1f..efc1edff1e15d 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -382,6 +382,10 @@ &gpu {
>  	operating-points-v2 = <&gpu_opp_table>;
>  };
>  
> +&hdmi_sound {
> +	simple-audio-card,name = "RK3568 HDMI";
> +}

[Severity: Low]
Is it possible this missing semicolon also causes a syntax error here?

Similar to the rk3566-base.dtsi change, this introduces a fatal syntax error
when building device trees that include rk3568.dtsi.

> +
>  &pipegrf {
>  	compatible = "rockchip,rk3568-pipe-grf", "syscon";
>  };

[ ... ]

> diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> index a5832895bd392..1a4562df20ee5 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> @@ -150,7 +150,6 @@ scmi_clk: protocol@14 {
>  
>  	hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
> -		simple-audio-card,name = "HDMI";

[Severity: Critical]
Does removing the established ALSA card name introduce a regression for
userspace ABI compatibility?

Changing the ALSA sound card name from HDMI to the SoC-specific strings
breaks existing userspace ALSA UCM profiles, PulseAudio configurations,
and routing rules that match on this exact original string.

>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <256>;
>  		status = "disabled";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-fix-rockchip-hdmi-audio-names-v2-0-1396a6168e20@collabora.com?part=6