Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: msm8994-octagon: Remove ad7147_captouch
@ 2026-09-11  8:43 Konrad Dybcio
  2026-09-11  8:49 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Konrad Dybcio @ 2026-09-11  8:43 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

This node lacks dt-bindings, producing warnings and is reportedly only
present on prototype hardware.

Remove it to get rid of the warnings.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
index 7ace3540ef0a..4da448f17133 100644
--- a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
@@ -377,19 +377,6 @@ &blsp1_uart2 {
 &blsp2_i2c1 {
 	status = "okay";
 
-	sideinteraction: touch@2c {
-		compatible = "adi,ad7147_captouch";
-		reg = <0x2c>;
-
-		pinctrl-names = "default", "sleep";
-		pinctrl-0 = <&grip_default>;
-		pinctrl-1 = <&grip_sleep>;
-
-		interrupts = <&tlmm 96 IRQ_TYPE_EDGE_FALLING>;
-
-		vcc-supply = <&vreg_l18a_2p85>;
-	};
-
 	/*
 	 * The QPDS-T900/QPDS-T930 is a customized part built for Nokia
 	 * by Avago. It is very similar to the Avago APDS-9930 with some

---
base-commit: f2bfbc3554ca6919484030729424b9dee2942d24
change-id: 20260911-topic-lumia_drop_captouch-c0db99b016a0

Best regards,
--  
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: qcom: msm8994-octagon: Remove ad7147_captouch
  2026-09-11  8:43 [PATCH] arm64: dts: qcom: msm8994-octagon: Remove ad7147_captouch Konrad Dybcio
@ 2026-09-11  8:49 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-09-11  8:49 UTC (permalink / raw)
  To: Konrad Dybcio; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The pinctrl nodes `grip_default` and `grip_sleep` were left behind and are now orphaned after their only consumer was removed.
--

commit 8167d39c59a24f7cde908c6c1d4da051dc5c0ffb
Author: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

arm64: dts: qcom: msm8994-octagon: Remove ad7147_captouch
    
This node lacks dt-bindings, producing warnings and is reportedly only
present on prototype hardware. The commit removes it to get rid of the warnings.

> diff --git a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
> index 7ace3540ef0a0..4da448f17133e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
> @@ -377,19 +377,6 @@ &blsp1_uart2 {
>  &blsp2_i2c1 {
>  	status = "okay";
>  
> -	sideinteraction: touch@2c {
> -		compatible = "adi,ad7147_captouch";
> -		reg = <0x2c>;
> -
> -		pinctrl-names = "default", "sleep";
> -		pinctrl-0 = <&grip_default>;
> -		pinctrl-1 = <&grip_sleep>;

[Severity: Low]
Since this touch node was their only consumer, the grip_default and
grip_sleep pinctrl nodes are now orphaned. Should their definitions
also be removed from the device tree?

> -
> -		interrupts = <&tlmm 96 IRQ_TYPE_EDGE_FALLING>;
> -
> -		vcc-supply = <&vreg_l18a_2p85>;
> -	};
> -
>  	/*
>  	 * The QPDS-T900/QPDS-T930 is a customized part built for Nokia
>  	 * by Avago. It is very similar to the Avago APDS-9930 with some

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-topic-lumia_drop_captouch-v1-1-6f92f1f3c6d3@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-11  8:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-11  8:43 [PATCH] arm64: dts: qcom: msm8994-octagon: Remove ad7147_captouch Konrad Dybcio
2026-09-11  8:49 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox