Devicetree
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Andre Gilerson <andre.gilerson@gmail.com>,
	Dan Scally <dan.scally@ideasonboard.com>,
	Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	German Pablo Lindo <germanpapulindez@gmail.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] media: i2c: Add Sony IMX681 sensor driver
Date: Fri, 11 Sep 2026 09:24:55 +0000	[thread overview]
Message-ID: <20260911092443.68221-1-lsa.uz@pm.me> (raw)
In-Reply-To: <20260911-lovely-khaki-inchworm-a13bb2@quoll>

All three taken, and this answers your note on 1/3 as well. One of them is
wider than you flagged.

- MAINTAINERS `T:` dropped. You are right that we have no commit rights there,
  and the convention agrees: 14 of 96 drivers/media/i2c entries carry a `T:`
  line and 82 do not.

- `dev_err` then `return ret` after devm_cci_regmap_init_i2c() becomes
  dev_err_probe(). The same shape is in twelve other probe-path sites, so v4
  converts all thirteen rather than only the one quoted. The seven in
  imx681_start_streaming(), imx681_stop_streaming() and imx681_power_on() stay
  as they are - power_on() is reached from runtime-PM resume as well as from
  probe, so it is not a probe path.

- The clk_get_rate() dev_dbg goes.

Recorded for v4: your Reviewed-by, on 1/3 where you gave it. German supplied a
full name after your note - German Pablo Lindo - and his Tested-by goes on 2/3
and nowhere else, since as you say it does not apply to a binding.

v4 is not sent today, and the reason is the other thing you asked for: André
should ack the binding, and he is away until 28 September. Rather than respin
twice I will hold briefly for that and for any comment on 2/3 and 3/3 on their
merits, then send once.

Sergey


  reply	other threads:[~2026-09-11  9:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 20:37 [PATCH v3 0/3] media: Add support for the Sony IMX681 Sergey Lebedev
2026-09-09 20:37 ` [PATCH v3 1/3] dt-bindings: media: Add " Sergey Lebedev
2026-09-11  7:36   ` Krzysztof Kozlowski
2026-09-09 20:37 ` [PATCH v3 2/3] media: i2c: Add Sony IMX681 sensor driver Sergey Lebedev
2026-09-09 20:52   ` sashiko-bot
2026-09-09 21:14   ` Sergey Lebedev
2026-09-11  7:38   ` Krzysztof Kozlowski
2026-09-11  9:24     ` Sergey Lebedev [this message]
2026-09-09 20:37 ` [PATCH v3 3/3] media: ipu-bridge: Add Sony IMX681 Sergey Lebedev
2026-09-09 20:46   ` sashiko-bot
2026-09-10 10:36 ` Test for [PATCH v3 0/3] media: Add support for the " German
2026-09-10 11:22   ` Sergey Lebedev
2026-09-10 11:48     ` Test on another machine and userspace for [PATCH v3 0/3] media: Add support for the Sony IMX681 Thanks for clarifying the origin of the errors I am more than happy to provide the tag Tested-by: German <germanpapulindez@gmail.com> German
2026-09-10 11:53     ` Test on another machine and userspace for [PATCH v3 0/3] media: Add support for the Sony IMX681 German
2026-09-11  7:35       ` Krzysztof Kozlowski
2026-09-12 16:16 ` cause of the image error in Gnome Snapshot " German

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911092443.68221-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=andre.gilerson@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=germanpapulindez@gmail.com \
    --cc=hansg@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox