Re: [PATCH v4 2/3] dt-bindings: arm: altera: add Draeger M48 Module

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message erroneously describes the Draeger M48 CPU module as an NXP i.MX6 based board, but the bindings correctly place it under the Altera Cyclone 5 SoC platform.
--

commit 7e951377f9aeb640e72ba7c48aafcccf11752d1e
Author: Petko Manolov <petko.manolov@konsulko.com>

dt-bindings: arm: altera: add Draeger M48 Module

This commit adds a new device tree compatible string for the Draeger M48
CPU module to the Altera device tree bindings.

>     dt-bindings: arm: altera: add Draeger M48 Module
>     
>     Add DT compatible string for Draeger's M48 CPU Module, an i.MX6
>     based board.

[Severity: Medium]
Is the description of the board architecture accurate here? The commit message
states the hardware is an i.MX6 based board (an NXP architecture), but the
patch correctly adds the compatible string under properties:compatible:oneOf
in Documentation/devicetree/bindings/arm/altera.yaml, which places it under
the Altera Cyclone 5 platform bindings.

While a subsequent patch in the series confirms the board is indeed a Cyclone 5
device, it also repeats the same i.MX6 claim in its commit message.

Should this regression in the commit description be corrected to prevent
misleading architectural information from polluting the git history?

> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index 3030cf46fe74c..8ed1ba7335103 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -47,6 +47,7 @@ properties:
>            - enum:
>                - altr,socfpga-cyclone5-socdk
>                - denx,mcvevk
> +              - draeger,M48
>                - ebv,socrates
>                - macnica,sodia
>                - novtech,chameleon96

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911150755.2803736-1-petko.manolov@konsulko.com?part=2