From: Krzysztof Kozlowski <krzk@kernel.org>
To: Petko Manolov <petko.manolov@konsulko.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dinguyen@kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: arm: altera: add Draeger M48 Module
Date: Sun, 13 Sep 2026 16:20:54 +0200 [thread overview]
Message-ID: <565e4f26-69c3-4129-b4f1-29d67c381591@kernel.org> (raw)
In-Reply-To: <20260913133214.GF20345@cabron.k.g>
On 13/09/2026 15:32, Petko Manolov wrote:
> On 26-09-13 11:18:16, Krzysztof Kozlowski wrote:
>> On Fri, Sep 11, 2026 at 06:07:53PM +0300, Petko Manolov wrote:
>>> Add DT compatible string for Draeger's M48 CPU Module, an i.MX6
>>> based board.
>>
>> Sashiko comment is valid.
>
> Sashiko doesn't know that this is indeed an i.MX6q board with the Altera FPGA as
> a separate module, that is secondary to the NXP SoC.
>
> What do you want me to put in the commit message so that everyone is happy?
Your commit msgs for bindings and DTS should explain the hardware and
with the current explanation this is just so incomplete that basically
wrong. i.mx6 is completely different vendor. Altera FPGA does not make
it Altera SoCFPGA, these are two different things. If Linux runs on
iMX6, then what are you describing here? DTS which never is going to be
loaded because there is no SocFPGA?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-13 14:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 15:07 [PATCH v4 0/3] arm: dts: altera: add Draeger M48 CPU Module Petko Manolov
2026-09-11 15:07 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: add Draeger AG Petko Manolov
2026-09-11 15:07 ` [PATCH v4 2/3] dt-bindings: arm: altera: add Draeger M48 Module Petko Manolov
2026-09-11 15:14 ` sashiko-bot
2026-09-13 9:18 ` Krzysztof Kozlowski
2026-09-13 13:32 ` Petko Manolov
2026-09-13 14:20 ` Krzysztof Kozlowski [this message]
2026-09-11 15:07 ` [PATCH v4 3/3] arm: dts: altera: add Draeger M48 CPU Module Petko Manolov
2026-09-11 15:18 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565e4f26-69c3-4129-b4f1-29d67c381591@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petko.manolov@konsulko.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox