Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: pankaj.gupta@oss.nxp.com
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
	Frank.Li@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v50 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc
Date: Sat, 12 Sep 2026 11:45:13 +0000	[thread overview]
Message-ID: <20260912114513.9CD7B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260912-imx-se-if-v50-2-80834ef510d3@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Discrepancy in the documented compatible string for i.MX95.
--

commit fadaa2081933a0613e667a53214f0c48c9bcd198
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

dt-bindings: arm: fsl: add imx-se-fw binding doc

This commit adds the device tree binding documentation for the NXP
i.MX Hardware Secure Enclave(s) EdgeLock Enclave. It defines the
communication interface using messaging units and specifies compatible
strings for i.MX8ULP, i.MX93, and i.MX95.

> diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml
> new file mode 100644
> index 0000000000000..fa81adbf9b80d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx8ulp-se-ele-hsm
> +      - fsl,imx93-se-ele-hsm
> +      - fsl,imx95-se-ele-hsm

[Severity: Medium]
Is there a discrepancy with the compatible string intended for i.MX95?

The binding here specifies fsl,imx95-se-ele-hsm, but in patch 1/7
of this series, the firmware documentation in 
Documentation/driver-api/firmware/other_interfaces.rst states that it
is using the single compatible node fsl,imx95-se.

Could this mismatch cause confusion for device tree authors and driver
maintainers regarding which compatible string is actually expected?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-imx-se-if-v50-0-80834ef510d3@nxp.com?part=2

  reply	other threads:[~2026-09-12 11:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12 17:03 [PATCH v50 0/7] firmware: imx: driver for NXP secure-enclave pankaj.gupta
2026-09-12 17:03 ` [PATCH v50 1/7] Documentation/firmware: add imx/se to other_interfaces pankaj.gupta
2026-09-12 11:44   ` sashiko-bot
2026-09-12 17:03 ` [PATCH v50 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc pankaj.gupta
2026-09-12 11:45   ` sashiko-bot [this message]
2026-09-12 17:03 ` [PATCH v50 3/7] firmware: imx: add driver for NXP EdgeLock Enclave pankaj.gupta
2026-09-12 11:46   ` sashiko-bot
2026-09-12 17:03 ` [PATCH v50 4/7] firmware: imx: device context dedicated to priv pankaj.gupta
2026-09-12 17:03 ` [PATCH v50 5/7] firmware: imx: adds miscdev pankaj.gupta
2026-09-12 11:48   ` sashiko-bot
2026-09-12 12:04     ` Pankaj Gupta (OSS)
2026-09-12 17:03 ` [PATCH v50 6/7] arm64: dts: imx8ulp: add secure enclave node pankaj.gupta
2026-09-12 11:45   ` sashiko-bot
2026-09-12 17:03 ` [PATCH v50 7/7] arm64: dts: imx8ulp: add reserved memory for EdgeLock Enclave pankaj.gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260912114513.9CD7B1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=pankaj.gupta@oss.nxp.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox