Re: [PATCH v50 3/7] firmware: imx: add driver for NXP EdgeLock Enclave

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Failing with `-ENOMEM` when `of_gen_pool_get` returns NULL breaks probe ordering and prevents the driver from binding if the SRAM pool probes later.
--

commit 88805176a44f81db2011a6e6ac5791578da01f8f
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

firmware: imx: add driver for NXP EdgeLock Enclave

This commit adds an MU-based communication interface for the secure enclave.
The NXP hardware IP for secure-enclaves, like Edgelock Enclave (ELE), is
embedded in the SoC to support features like HSM, SHE & V2X.

> diff --git a/drivers/firmware/imx/se_ctrl.c b/drivers/firmware/imx/se_ctrl.c
> new file mode 100644
> index 0000000000000..0013c960ec43d
> --- /dev/null
> +++ b/drivers/firmware/imx/se_ctrl.c

[ ... ]

> +static int se_if_probe(struct platform_device *pdev)
> +{

[ ... ]

> +	if (if_node->pool_name) {
> +		priv->mem_pool = of_gen_pool_get(dev->of_node, if_node->pool_name, 0);
> +		if (!priv->mem_pool)
> +			return dev_err_probe(dev, -ENOMEM,
> +					     "Unable to get sram pool = %s.\n",
> +					     if_node->pool_name);
> +	}

[Severity: Medium]
Could this prevent the driver from binding if the SRAM pool probes later?

During system boot, if the SRAM driver defers its probe (for example, due to
pending clock or regulator dependencies), of_gen_pool_get() will return NULL.

By unconditionally returning -ENOMEM here, does the secure enclave driver
permanently abort its initialization in se_if_probe() instead of returning
-EPROBE_DEFER to try again later? This would break all dependent functionality
like HSM, SHE, and V2X on configurations where the SRAM pool probes later.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-imx-se-if-v50-0-80834ef510d3@nxp.com?part=3