From: sashiko-bot@kernel.org
To: "Kendall Willis" <k-willis@ti.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] arm64: dts: ti: k3-am62: use ti,am62-mcan compatible for m_can devices
Date: Sat, 12 Sep 2026 21:40:43 +0000 [thread overview]
Message-ID: <20260912214044.48B3F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260912-smth-v3-1-6fa661ae5a4c@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible string 'ti,am62-mcan' is used in the device tree but is not documented in the dt-bindings, causing dtbs validation failures.
--
commit 38209444ad0c4e93f314506da051123caab882d5
Author: Kendall Willis <k-willis@ti.com>
arm64: dts: ti: k3-am62: use ti,am62-mcan compatible for m_can devices
This commit prepends the ti,am62-mcan compatible string to m_can devices
in the AM62 device trees to indicate out-of-band wakeup capabilities.
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index c5ee263d34a62..4c7e793d84a0e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -933,7 +933,7 @@ eqep2: counter@23220000 {
> };
>
> main_mcan0: can@20701000 {
> - compatible = "bosch,m_can";
> + compatible = "ti,am62-mcan", "bosch,m_can";
[Severity: Low]
Is the ti,am62-mcan compatible string documented in the dt-bindings?
Running make dtbs_check on the generated device trees for k3-am62 platforms
will fail validation because the dt-binding for bosch,m_can strictly requires
the compatible property to be const: bosch,m_can and does not accept the new
ti,am62-mcan string or an array of strings.
Does this patch depend on a separate dt-bindings update that needs to be
applied first, or should the bosch,m_can binding be updated alongside this
change?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-smth-v3-0-6fa661ae5a4c@ti.com?part=1
next prev parent reply other threads:[~2026-09-12 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 21:32 [PATCH v3 0/3] arm64: dts: ti: use ti,am62-mcan compatible for m_can devices Kendall Willis
2026-09-12 21:32 ` [PATCH v3 1/3] arm64: dts: ti: k3-am62: " Kendall Willis
2026-09-12 21:40 ` sashiko-bot [this message]
2026-09-12 21:32 ` [PATCH v3 2/3] arm64: dts: ti: k3-am62a: " Kendall Willis
2026-09-12 21:40 ` sashiko-bot
2026-09-12 21:32 ` [PATCH v3 3/3] arm64: dts: ti: k3-am62p: " Kendall Willis
2026-09-12 21:41 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912214044.48B3F1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k-willis@ti.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox