From: sashiko-bot@kernel.org
To: "Kendall Willis" <k-willis@ti.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: ti: k3-am62p: use ti,am62-mcan compatible for m_can devices
Date: Sat, 12 Sep 2026 21:41:20 +0000 [thread overview]
Message-ID: <20260912214121.572441F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260912-smth-v3-3-6fa661ae5a4c@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string 'ti,am62-mcan' is not documented or permitted by the corresponding device tree binding schema.
--
commit c9a5bd5e593b159b3d44f9ab0c75ab2dacec0f49
Author: Kendall Willis <k-willis@ti.com>
arm64: dts: ti: k3-am62p: use ti,am62-mcan compatible for m_can devices
This commit prepends the "ti,am62-mcan" compatible string to the m_can devices
in the device tree for the AM62p. The new compatible string adds out-of-band
wakeup functionality.
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> index f130c7cb998d7..9e8d9246f6169 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> @@ -883,7 +883,7 @@ eqep2: counter@23220000 {
> };
>
> main_mcan0: can@20701000 {
> - compatible = "bosch,m_can";
> + compatible = "ti,am62-mcan", "bosch,m_can";
[Severity: Low]
Does this change cause make dtbs_check to fail for the main_mcan0 and
main_mcan1 nodes?
Looking at Documentation/devicetree/bindings/net/can/bosch,m_can.yaml, the
schema expects the compatible property to be exactly the constant string:
compatible:
const: bosch,m_can
Without updating the device tree binding schema to permit the new
"ti,am62-mcan" string alongside "bosch,m_can", it appears the schema
validation will reject these nodes.
[ ... ]
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> index 5288c959f3c1a..3db8b63ef01fe 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> @@ -154,7 +154,7 @@ mcu_rti0: watchdog@4880000 {
> };
>
> mcu_mcan0: can@4e08000 {
> - compatible = "bosch,m_can";
> + compatible = "ti,am62-mcan", "bosch,m_can";
[Severity: Low]
Will this also trigger a dtbs_check validation failure for the mcu_mcan0 and
mcu_mcan1 nodes?
The same schema documentation issue applies here. Is there a missing
prerequisite patch to update the yaml binding?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-smth-v3-0-6fa661ae5a4c@ti.com?part=3
prev parent reply other threads:[~2026-09-12 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 21:32 [PATCH v3 0/3] arm64: dts: ti: use ti,am62-mcan compatible for m_can devices Kendall Willis
2026-09-12 21:32 ` [PATCH v3 1/3] arm64: dts: ti: k3-am62: " Kendall Willis
2026-09-12 21:40 ` sashiko-bot
2026-09-12 21:32 ` [PATCH v3 2/3] arm64: dts: ti: k3-am62a: " Kendall Willis
2026-09-12 21:40 ` sashiko-bot
2026-09-12 21:32 ` [PATCH v3 3/3] arm64: dts: ti: k3-am62p: " Kendall Willis
2026-09-12 21:41 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912214121.572441F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k-willis@ti.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox