[PATCH 0/2] arm64: dts: st: add dcmi nodes in stm32mp231 / stm32mp251

[PATCH 0/2] arm64: dts: st: add dcmi nodes in stm32mp231 / stm32mp251

[Alain Volmat]

STM32MP23 and STM32MP25 embed a Digital Camera Interface (DCMI)
block allowing to capture frames via a parallel interface.
Add the dcmi nodes in both stm32mp231.dtsi and stm32mp251.dtsi
describing this HW block.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
Alain Volmat (2):
      arm64: dts: st: add dcmi node on stm32mp25x
      arm64: dts: st: add dcmi node on stm32mp23x

 arch/arm64/boot/dts/st/stm32mp231.dtsi | 14 ++++++++++++++
 arch/arm64/boot/dts/st/stm32mp251.dtsi | 14 ++++++++++++++
 2 files changed, 28 insertions(+)
---
base-commit: 2f92d900f262a16c8ae02daf53ae2910d07185f5
change-id: 20260914-stm32mp2x-dcmi-9fd57ababe6c

Best regards,
--  
Alain Volmat <alain.volmat@foss.st.com>

[PATCH 1/2] arm64: dts: st: add dcmi node on stm32mp25x

[Alain Volmat]

Add the node for the DCMI controller in stm32mp251.dtsi

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
 arch/arm64/boot/dts/st/stm32mp251.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
index 44938c036e30..4987ebcd8556 100644
--- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
+++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
@@ -1450,6 +1450,20 @@ uart8: serial@40380000 {
 				status = "disabled";
 			};
 
+			dcmi: dcmi@404a0000 {
+				compatible = "st,stm32-dcmi";
+				reg = <0x404a0000 0x400>;
+				interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+				resets = <&rcc CCI_R>;
+				clocks = <&rcc CK_BUS_CCI>;
+				clock-names = "mclk";
+				dmas = <&hpdma 137 0x60 0x00003012>;
+				dma-names = "tx";
+				access-controllers = <&rifsc 88>;
+				power-domains = <&CLUSTER_PD>;
+				status = "disabled";
+			};
+
 			rng: rng@42020000 {
 				compatible = "st,stm32mp25-rng";
 				reg = <0x42020000 0x400>;

-- 
2.34.1

[PATCH 2/2] arm64: dts: st: add dcmi node on stm32mp23x

[Alain Volmat]

Add the node for the DCMI controller in stm32mp231.dtsi

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
 arch/arm64/boot/dts/st/stm32mp231.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
index 0feb8943efae..ad008049384b 100644
--- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
+++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
@@ -646,6 +646,20 @@ uart7: serial@40370000 {
 				status = "disabled";
 			};
 
+			dcmi: dcmi@404a0000 {
+				compatible = "st,stm32-dcmi";
+				reg = <0x404a0000 0x400>;
+				interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+				resets = <&rcc CCI_R>;
+				clocks = <&rcc CK_BUS_CCI>;
+				clock-names = "mclk";
+				dmas = <&hpdma 137 0x60 0x00003012>;
+				dma-names = "tx";
+				access-controllers = <&rifsc 88>;
+				power-domains = <&cluster_pd>;
+				status = "disabled";
+			};
+
 			rng: rng@42020000 {
 				compatible = "st,stm32mp25-rng";
 				reg = <0x42020000 0x400>;

-- 
2.34.1

Re: [PATCH 2/2] arm64: dts: st: add dcmi node on stm32mp23x

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing unconditionally required 'port' property in the newly added 'dcmi' node, causing a dtbs_check warning.
--

commit 42a2863a4d17c3ffce4549b0b100b843b4aeb937
Author: Alain Volmat <alain.volmat@foss.st.com>

arm64: dts: st: add dcmi node on stm32mp23x

This commit adds the devicetree node for the DCMI controller in the
stm32mp231.dtsi include file.

> diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> index 0feb8943efae6..ad008049384b7 100644
> --- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> @@ -646,6 +646,20 @@ uart7: serial@40370000 {
>  				status = "disabled";
>  			};
>  
> +			dcmi: dcmi@404a0000 {
> +				compatible = "st,stm32-dcmi";
> +				reg = <0x404a0000 0x400>;
> +				interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> +				resets = <&rcc CCI_R>;
> +				clocks = <&rcc CK_BUS_CCI>;
> +				clock-names = "mclk";
> +				dmas = <&hpdma 137 0x60 0x00003012>;
> +				dma-names = "tx";
> +				access-controllers = <&rifsc 88>;
> +				power-domains = <&cluster_pd>;
> +				status = "disabled";
> +			};

[Severity: Low]
Does this node need a 'port' property to satisfy the st,stm32-dcmi.yaml
dt-binding?

While the driver safely handles a missing endpoint in dcmi_probe() by
returning -ENODEV:

drivers/media/platform/st/stm32/stm32-dcmi.c:dcmi_probe() {
	...
	np = of_graph_get_endpoint_by_regs(np, 0, -1);
	if (!np) {
		dev_err(&pdev->dev, "Could not find the endpoint\n");
		return -ENODEV;
	}
	...
}

the binding schema unconditionally requires the port property, which will
trigger a dtbs_check warning when omitted.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-stm32mp2x-dcmi-v1-0-c594e081d21b@foss.st.com?part=2