Devicetree
 help / color / mirror / Atom feed
* [PATCH v1] arm64: dts: freescale: imx8mp-toradex-smarc: fix SMARC_SLEEP# gpio-line-names typo
@ 2026-09-15 20:14 Francesco Dolcini
  2026-09-23 19:58 ` Frank.Li
  0 siblings, 1 reply; 2+ messages in thread
From: Francesco Dolcini @ 2026-09-15 20:14 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
	linux-kernel, stable

From: Francesco Dolcini <francesco.dolcini@toradex.com>

gpio3's gpio-line-names has "SLEEP#" instead of "SMARC_SLEEP#" for the
SMARC SLEEP# connector signal, while the gpio-keys node driven by the
very same GPIO line already labels it "SMARC_SLEEP#", and the imx95
Toradex SMARC variant names the equivalent line "SMARC_SLEEP#" too.

GPIO line names are meant to be stable across the whole Toradex SMARC
family, using the official SMARC-connector signal names from the
SMARC specification and the SoM datasheet's pin assignment table, so
userspace GPIO tooling that looks up a line by name works the same on
any Toradex SMARC board.

Fixes: 97dc91c04558 ("arm64: dts: freescale: add Toradex SMARC iMX8MP")
Cc: stable@vger.kernel.org
Assisted-by: LLM
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-toradex-smarc.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-toradex-smarc.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-toradex-smarc.dtsi
index 0348da385f23..eb8b9db7e3cd 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-toradex-smarc.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-toradex-smarc.dtsi
@@ -323,7 +323,7 @@ &gpio3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_lvds_dsi_sel>;
 	gpio-line-names = "ETH_0_INT#", /* 0 */
-			  "SLEEP#",
+			  "SMARC_SLEEP#",
 			  "",
 			  "",
 			  "",
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] arm64: dts: freescale: imx8mp-toradex-smarc: fix SMARC_SLEEP# gpio-line-names typo
  2026-09-15 20:14 [PATCH v1] arm64: dts: freescale: imx8mp-toradex-smarc: fix SMARC_SLEEP# gpio-line-names typo Francesco Dolcini
@ 2026-09-23 19:58 ` Frank.Li
  0 siblings, 0 replies; 2+ messages in thread
From: Frank.Li @ 2026-09-23 19:58 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Francesco Dolcini
  Cc: Frank Li, Francesco Dolcini, devicetree, imx, linux-arm-kernel,
	linux-kernel, stable

From: Frank Li <Frank.Li@nxp.com>


On Tue, 15 Sep 2026 22:14:10 +0200, Francesco Dolcini wrote:
> gpio3's gpio-line-names has "SLEEP#" instead of "SMARC_SLEEP#" for the
> SMARC SLEEP# connector signal, while the gpio-keys node driven by the
> very same GPIO line already labels it "SMARC_SLEEP#", and the imx95
> Toradex SMARC variant names the equivalent line "SMARC_SLEEP#" too.
> 
> GPIO line names are meant to be stable across the whole Toradex SMARC
> family, using the official SMARC-connector signal names from the
> SMARC specification and the SoM datasheet's pin assignment table, so
> userspace GPIO tooling that looks up a line by name works the same on
> any Toradex SMARC board.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: freescale: imx8mp-toradex-smarc: fix SMARC_SLEEP# gpio-line-names typo
      commit: 90bc5a53c7f0733ec37a5c041b4e1aefa3d8d965

Best regards,
-- 
Frank Li <Frank.Li@nxp.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-23 19:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-15 20:14 [PATCH v1] arm64: dts: freescale: imx8mp-toradex-smarc: fix SMARC_SLEEP# gpio-line-names typo Francesco Dolcini
2026-09-23 19:58 ` Frank.Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox