Re: [PATCH 2/2] ARM: dts: ux500: Drop AB8505 main charger interrupts

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] power: ab8500: probe fails due to missing main charger interrupts
--

commit e7da031c5be9d239332af239a1c3e397eaa17b40
Author: Linus Walleij <linusw@kernel.org>

ARM: dts: ux500: Drop AB8505 main charger interrupts

The AB8505 interrupt table explicitly omits the five interrupt
sources belonging to the AB8500 main charger. Remove these nonexistent
interrupts from the AB8505 charger node, leaving its nine USB charger
interrupts.

> diff --git a/arch/arm/boot/dts/st/ste-ab8505.dtsi b/arch/arm/boot/dts/st/ste-ab8505.dtsi
> index 131c82508e820..f7208e689d093 100644
> --- a/arch/arm/boot/dts/st/ste-ab8505.dtsi
> +++ b/arch/arm/boot/dts/st/ste-ab8505.dtsi
> @@ -138,12 +138,7 @@ ab8500_btemp {
>  
>  				ab8500_charger {
>  					compatible = "stericsson,ab8500-charger";
> -					interrupts = <10 IRQ_TYPE_LEVEL_HIGH>,
> -						     <11 IRQ_TYPE_LEVEL_HIGH>,
> -						     <0 IRQ_TYPE_LEVEL_HIGH>,
> -						     <107 IRQ_TYPE_LEVEL_HIGH>,
> -						     <106 IRQ_TYPE_LEVEL_HIGH>,
> -						     <14 IRQ_TYPE_LEVEL_HIGH>,
> +					interrupts = <14 IRQ_TYPE_LEVEL_HIGH>,

[Severity: High]
Does removing these interrupts cause a probe failure in the ab8500_charger
driver?

Looking at ab8500_charger_probe() in drivers/power/supply/ab8500_charger.c, it
iterates over a hardcoded array of 14 interrupts:

	for (i = 0; i < ARRAY_SIZE(ab8500_charger_irq); i++) {
		irq = platform_get_irq_byname(pdev, ab8500_charger_irq[i].name);
		if (irq < 0)
			return irq;

Since this patch removes 5 main charger interrupts (including
"MAIN_CH_UNPLUG_DET") from the device tree, platform_get_irq_byname() will
return an error (like -ENXIO) for those missing interrupts.

Will this cause the probe function to immediately abort, completely breaking
charging functionality on the AB8505 platform?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-ab8500-charger-dt-v1-0-10b7b387e6a6@kernel.org?part=2