Re: [PATCH 1/2] dt-bindings: power: supply: ab8500: Allow AB8505 interrupts

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] power: supply: ab8500: fatal probe failure when using 9-interrupt configuration
--

commit 8052a5eb029696fb98fcaf52a7b6b4012177809a
Author: Linus Walleij <linusw@kernel.org>

dt-bindings: power: supply: ab8500: Allow AB8505 interrupts

AB8505 has no main charger or main-charger interrupts. Permit its
nine USB charger interrupts as an alternative to the full set of
fourteen AB8500 interrupts.

> diff --git a/Documentation/devicetree/bindings/power/supply/stericsson,ab8500-charger.yaml b/Documentation/devicetree/bindings/power/supply/stericsson,ab8500-charger.yaml
> index 4f19744844e9c..437b58e82e9ae 100644
> --- a/Documentation/devicetree/bindings/power/supply/stericsson,ab8500-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/stericsson,ab8500-charger.yaml
[ ... ]
>    autopower_cfg:
>      type: boolean
> -    description: automatic poweron after powerloss
> +    description: AB8500 automatic poweron after powerloss
>  
>    interrupts:
> +    minItems: 9
>      maxItems: 14
>  
>    interrupt-names:

[Severity: High]
Does this binding relaxation lead to a fatal probe failure when the
9-interrupt configuration is used?

During initialization, ab8500_charger_probe() unconditionally loops over the
statically defined 14-element ab8500_charger_irq array:

drivers/power/supply/ab8500_charger.c:ab8500_charger_probe() {
    ...
	for (i = 0; i < ARRAY_SIZE(ab8500_charger_irq); i++) {
		irq = platform_get_irq_byname(pdev, ab8500_charger_irq[i].name);
		if (irq < 0)
			return irq;
    ...
}

When the driver attempts to request one of the missing main charger
interrupts via platform_get_irq_byname(), it will return a negative error
code and immediately abort the probe.

This would break battery charging and power management entirely on hardware
using the 9-interrupt DT configuration.

A later patch in this series, ARM: dts: ux500: Drop AB8505 main charger
interrupts, applies this 9-interrupt configuration to the DTS without
updating the driver, which will cause the driver to fail to load on boot.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-ab8500-charger-dt-v1-0-10b7b387e6a6@kernel.org?part=1