Re: [PATCH v2 4/4] regulator: dt-bindings: ti,tps6586x: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing labels for phandle references in example
--

commit 2ba7135b970f955684609cafbc16f7eead707402
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

regulator: dt-bindings: ti,tps6586x: Convert to DT schema

Convert Texas Instruments tps6586x regulator binding from text to DT schema
and add tegra-regulators-coupling reference in child regulator nodes.

> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> new file mode 100644
> index 0000000000000..1f7c7b35066f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml

[ ... ]

> +          sys-supply = <&vdd_5v0_sys>;
> +          vin-sm0-supply = <&sys_reg>;
> +          vin-sm1-supply = <&sys_reg>;
> +          vin-sm2-supply = <&sys_reg>;
> +          vinldo01-supply = <&sm2_reg>;
> +          vinldo23-supply = <&sm2_reg>;
> +          vinldo4-supply = <&sm2_reg>;
> +          vinldo678-supply = <&sm2_reg>;
> +          vinldo9-supply = <&sm2_reg>;
> +
> +          regulators {
> +              sys {

[Severity: Low]
Does this example have missing labels for the phandle references?

The properties above reference &sys_reg and &sm2_reg, but the labels were
removed from the sys and sm2 nodes during the text to YAML conversion. Will
this leave the example structurally incomplete when compiled?

> +                  regulator-name = "vdd_sys";
> +                  regulator-boot-on;
> +                  regulator-always-on;
> +              };

[ ... ]

> +              sm2 {

[Severity: Low]
Could the sm2_reg label be restored here?

The earlier properties like vinldo01-supply expect it to exist to complete
the phandle reference.

> +                  regulator-min-microvolt = <3000000>;
> +                  regulator-max-microvolt = <4550000>;
> +                  regulator-boot-on;
> +                  regulator-always-on;
> +              };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-ti-tps6586x-v2-0-f12cfdfb446c@gmail.com?part=4