Re: [PATCH v2 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] regulator: dt-bindings: merged headers and missing spaces in description
--

commit c698037c054c9372f8a8e2ee437ab89f8f0611c7
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema
    
Convert NVIDIA Tegra Regulators Coupling from legacy text to DT schema.
Set additionalProperties true as this is shared schema.

> diff --git a/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml
> @@ -0,0 +1,76 @@

[ ... ]

> +description:
> +  NVIDIA Tegra SoC's have a mandatory voltage-coupling between regulators. Thus
> +  on Tegra20 there are 3 coupled regulators and on NVIDIA Tegra30 there are 2.
> +
> +  Tegra20 voltage coupling On Tegra20 SoC's - there are 3 coupled
> +  regulators:CORE, RTC and CPU. The CORE and RTC voltages shall be in a range
> +  of 170mV from each other and they both shall be higher than the CPU voltage
> +  by at least 120mV.
> +
> +  Tegra30 voltage coupling On Tegra30 SoC's - there are 2 coupled
> +  regulators:CORE and CPU. The CORE and CPU voltages shall be in a range of

[Severity: Low]
Could the formatting in this description be adjusted to better reflect the 
original text binding?

Currently, the old section headers like "Tegra20 voltage coupling" and 
"Tegra30 voltage coupling" are merged directly into the sentences, creating 
awkward phrasing like "Tegra20 voltage coupling On Tegra20 SoC's". 

Additionally, is it possible to add a space after "regulators:" in both the 
Tegra20 and Tegra30 paragraphs to improve readability?

> +  300mV from each other and CORE voltage shall be higher than the CPU by N mV,
> +  where N depends on the CPU voltage.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-ti-tps6586x-v2-0-f12cfdfb446c@gmail.com?part=2