Re: [PATCH 2/2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing required properties regulator-name and regulator-always-on
--

commit a3c16ba2973ce68a883eb4ccf0647aefc328d59f
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files

This commit removes obsolete text bindings for Versatile Express hwmon and
regulator nodes. A note regarding fixed supplies is moved into the existing
vexpress-config.yaml schema before removing regulator/vexpress.txt entirely.

> diff --git a/Documentation/devicetree/bindings/arm/vexpress-config.yaml b/Documentation/devicetree/bindings/arm/vexpress-config.yaml
> index 41c53e3acc12c..b04e8e0521815 100644
> --- a/Documentation/devicetree/bindings/arm/vexpress-config.yaml
> +++ b/Documentation/devicetree/bindings/arm/vexpress-config.yaml
> @@ -139,6 +139,10 @@ patternProperties:
>  
>    "^regulator-.+$":
>      $ref: /schemas/regulator/regulator.yaml#
> +    description:
> +      If regulator-min-microvolt and regulator-max-microvolt do not both
> +      define a range, the supply is treated as fixed and only its voltage
> +      can be read.

[Severity: Low]
The commit message states:
"The regulator node refers to regulator.yaml, which covers the generic
regulator properties the second file lists, and all 13 in-tree
arm,vexpress-volt nodes set both of the properties it calls required."

However, the deleted text file Documentation/devicetree/bindings/regulator/vexpress.txt
explicitly listed these two generic properties under "Required regulator properties":

- "regulator-name"
- "regulator-always-on"

While regulator.yaml defines these properties, it does not enforce them as
required. By removing the text binding without adding regulator-name and
regulator-always-on to the required list for the "^regulator-.+$" block here,
won't device trees omitting these properties now silently pass schema validation?

Should these properties be appended to the required list of this node to
maintain the strict constraints previously enforced by the deleted text binding?

>      properties:
>        compatible:
>          const: arm,vexpress-volt

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917115818.540344-1-quchaosheng000406@163.com?part=2