* [PATCH 2/2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files
@ 2026-09-17 11:58 Quchaosheng
2026-09-17 12:07 ` sashiko-bot
2026-09-24 22:23 ` Rob Herring (Arm)
0 siblings, 2 replies; 3+ messages in thread
From: Quchaosheng @ 2026-09-17 11:58 UTC (permalink / raw)
To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sudeep Holla, Liviu Dudau, Lorenzo Pieralisi
Cc: Jonathan Corbet, linux-hwmon, devicetree, linux-arm-kernel,
linux-doc, linux-kernel, Quchaosheng
Documentation/devicetree/bindings/hwmon/vexpress.txt describes the
arm,vexpress-volt, -amp, -temp, -power and -energy sensors, and
Documentation/devicetree/bindings/regulator/vexpress.txt describes the
arm,vexpress-volt regulator.
Both restate what arm/vexpress-config.yaml already documents: the same
compatibles, the arm,vexpress-sysreg,func property and the label property.
The regulator node refers to regulator.yaml, which covers the generic
regulator properties the second file lists, and all 13 in-tree
arm,vexpress-volt nodes set both of the properties it calls required.
One sentence in the regulator file is not a restatement: it says that a
supply without regulator-min-microvolt and regulator-max-microvolt is
treated as fixed. vexpress_regulator_probe() implements that by selecting
vexpress_regulator_ops_ro when the two properties do not both define a
range. Move the note into the regulator node description in the schema,
so that removing the file does not lose it.
Nothing else refers to the two files. Remove them.
Assisted-by: LLM
Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
---
.../bindings/arm/vexpress-config.yaml | 4 +++
.../devicetree/bindings/hwmon/vexpress.txt | 23 -------------
.../bindings/regulator/vexpress.txt | 32 -------------------
3 files changed, 4 insertions(+), 55 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/hwmon/vexpress.txt
delete mode 100644 Documentation/devicetree/bindings/regulator/vexpress.txt
diff --git a/Documentation/devicetree/bindings/arm/vexpress-config.yaml b/Documentation/devicetree/bindings/arm/vexpress-config.yaml
index 41c53e3acc12..b04e8e052181 100644
--- a/Documentation/devicetree/bindings/arm/vexpress-config.yaml
+++ b/Documentation/devicetree/bindings/arm/vexpress-config.yaml
@@ -139,6 +139,10 @@ patternProperties:
"^regulator-.+$":
$ref: /schemas/regulator/regulator.yaml#
+ description:
+ If regulator-min-microvolt and regulator-max-microvolt do not both
+ define a range, the supply is treated as fixed and only its voltage
+ can be read.
properties:
compatible:
const: arm,vexpress-volt
diff --git a/Documentation/devicetree/bindings/hwmon/vexpress.txt b/Documentation/devicetree/bindings/hwmon/vexpress.txt
deleted file mode 100644
index 4a4df4ffc460..000000000000
--- a/Documentation/devicetree/bindings/hwmon/vexpress.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-Versatile Express hwmon sensors
--------------------------------
-
-Requires node properties:
-- "compatible" value : one of
- "arm,vexpress-volt"
- "arm,vexpress-amp"
- "arm,vexpress-temp"
- "arm,vexpress-power"
- "arm,vexpress-energy"
-- "arm,vexpress-sysreg,func" when controlled via vexpress-sysreg
- (see Documentation/devicetree/bindings/arm/vexpress-config.yaml
- for more details)
-
-Optional node properties:
-- label : string describing the monitored value
-
-Example:
- energy@0 {
- compatible = "arm,vexpress-energy";
- arm,vexpress-sysreg,func = <13 0>;
- label = "A15 Jcore";
- };
diff --git a/Documentation/devicetree/bindings/regulator/vexpress.txt b/Documentation/devicetree/bindings/regulator/vexpress.txt
deleted file mode 100644
index 1c2e92c7831e..000000000000
--- a/Documentation/devicetree/bindings/regulator/vexpress.txt
+++ /dev/null
@@ -1,32 +0,0 @@
-Versatile Express voltage regulators
-------------------------------------
-
-Requires node properties:
-- "compatible" value: "arm,vexpress-volt"
-- "arm,vexpress-sysreg,func" when controlled via vexpress-sysreg
- (see Documentation/devicetree/bindings/arm/vexpress-config.yaml
- for more details)
-
-Required regulator properties:
-- "regulator-name"
-- "regulator-always-on"
-
-Optional regulator properties:
-- "regulator-min-microvolt"
-- "regulator-max-microvolt"
-
-See Documentation/devicetree/bindings/regulator/regulator.txt
-for more details about the regulator properties.
-
-When no "regulator-[min|max]-microvolt" properties are defined,
-the device is treated as fixed (or rather "read-only") regulator.
-
-Example:
- volt@0 {
- compatible = "arm,vexpress-volt";
- arm,vexpress-sysreg,func = <2 0>;
- regulator-name = "Cores";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <1050000>;
- regulator-always-on;
- };
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files
2026-09-17 11:58 [PATCH 2/2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files Quchaosheng
@ 2026-09-17 12:07 ` sashiko-bot
2026-09-24 22:23 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-09-17 12:07 UTC (permalink / raw)
To: Quchaosheng; +Cc: linux-hwmon, robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing required properties regulator-name and regulator-always-on
--
commit a3c16ba2973ce68a883eb4ccf0647aefc328d59f
Author: Quchaosheng <quchaosheng000406@163.com>
dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files
This commit removes obsolete text bindings for Versatile Express hwmon and
regulator nodes. A note regarding fixed supplies is moved into the existing
vexpress-config.yaml schema before removing regulator/vexpress.txt entirely.
> diff --git a/Documentation/devicetree/bindings/arm/vexpress-config.yaml b/Documentation/devicetree/bindings/arm/vexpress-config.yaml
> index 41c53e3acc12c..b04e8e0521815 100644
> --- a/Documentation/devicetree/bindings/arm/vexpress-config.yaml
> +++ b/Documentation/devicetree/bindings/arm/vexpress-config.yaml
> @@ -139,6 +139,10 @@ patternProperties:
>
> "^regulator-.+$":
> $ref: /schemas/regulator/regulator.yaml#
> + description:
> + If regulator-min-microvolt and regulator-max-microvolt do not both
> + define a range, the supply is treated as fixed and only its voltage
> + can be read.
[Severity: Low]
The commit message states:
"The regulator node refers to regulator.yaml, which covers the generic
regulator properties the second file lists, and all 13 in-tree
arm,vexpress-volt nodes set both of the properties it calls required."
However, the deleted text file Documentation/devicetree/bindings/regulator/vexpress.txt
explicitly listed these two generic properties under "Required regulator properties":
- "regulator-name"
- "regulator-always-on"
While regulator.yaml defines these properties, it does not enforce them as
required. By removing the text binding without adding regulator-name and
regulator-always-on to the required list for the "^regulator-.+$" block here,
won't device trees omitting these properties now silently pass schema validation?
Should these properties be appended to the required list of this node to
maintain the strict constraints previously enforced by the deleted text binding?
> properties:
> compatible:
> const: arm,vexpress-volt
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917115818.540344-1-quchaosheng000406@163.com?part=2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files
2026-09-17 11:58 [PATCH 2/2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files Quchaosheng
2026-09-17 12:07 ` sashiko-bot
@ 2026-09-24 22:23 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-09-24 22:23 UTC (permalink / raw)
To: Quchaosheng
Cc: Guenter Roeck, Conor Dooley, linux-arm-kernel, Sudeep Holla,
devicetree, linux-hwmon, Lorenzo Pieralisi, linux-kernel,
linux-doc, Jonathan Corbet, Krzysztof Kozlowski, Liviu Dudau
On Thu, 17 Sep 2026 19:58:18 +0800, Quchaosheng wrote:
> Documentation/devicetree/bindings/hwmon/vexpress.txt describes the
> arm,vexpress-volt, -amp, -temp, -power and -energy sensors, and
> Documentation/devicetree/bindings/regulator/vexpress.txt describes the
> arm,vexpress-volt regulator.
>
> Both restate what arm/vexpress-config.yaml already documents: the same
> compatibles, the arm,vexpress-sysreg,func property and the label property.
> The regulator node refers to regulator.yaml, which covers the generic
> regulator properties the second file lists, and all 13 in-tree
> arm,vexpress-volt nodes set both of the properties it calls required.
>
> One sentence in the regulator file is not a restatement: it says that a
> supply without regulator-min-microvolt and regulator-max-microvolt is
> treated as fixed. vexpress_regulator_probe() implements that by selecting
> vexpress_regulator_ops_ro when the two properties do not both define a
> range. Move the note into the regulator node description in the schema,
> so that removing the file does not lose it.
>
> Nothing else refers to the two files. Remove them.
>
> Assisted-by: LLM
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> ---
> .../bindings/arm/vexpress-config.yaml | 4 +++
> .../devicetree/bindings/hwmon/vexpress.txt | 23 -------------
> .../bindings/regulator/vexpress.txt | 32 -------------------
> 3 files changed, 4 insertions(+), 55 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/hwmon/vexpress.txt
> delete mode 100644 Documentation/devicetree/bindings/regulator/vexpress.txt
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-24 22:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-17 11:58 [PATCH 2/2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files Quchaosheng
2026-09-17 12:07 ` sashiko-bot
2026-09-24 22:23 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox