From: sashiko-bot@kernel.org
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: wsa+renesas@sang-engineering.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: r9a09g047e57-smarc: Sort nodes alphabetically
Date: Thu, 17 Sep 2026 12:31:22 +0000 [thread overview]
Message-ID: <20260917123123.2A1CB1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917122701.160720-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: incorrect node sorting breaks alphabetical order
--
commit 6d15dc9289c8e2de0fe2bc1d3748c8961dab0497
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
arm64: dts: renesas: r9a09g047e57-smarc: Sort nodes alphabetically
This commit moves the sound card node before the vqmmc regulator node
in the r9a09g047e57-smarc device tree, with the stated intent of maintaining
alphabetical ordering of the nodes under the root node.
> diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> index 4eed095b683b3..df5ec16d7dbdd 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> @@ -77,6 +77,14 @@ aliases {
> mmc1 = &sdhi1;
> };
>
> + sound_card: sound {
> + compatible = "audio-graph-card";
> +
> + label = "snd-rzg3e";
> +
> + dais = <&rsnd_port0>; /* DA7212 */
> + };
> +
> vqmmc_sd1_pvdd: regulator-vqmmc-sd1-pvdd {
[Severity: Low]
Does this actually maintain alphabetical ordering?
Standard Device Tree conventions dictate sorting nodes alphabetically by their
node names (the part after the colon), not their labels. Alphabetically by
node name, "regulator-vqmmc-sd1-pvdd" comes before "sound".
It appears this moves the "sound" node before the regulator node by mistake,
perhaps by sorting the labels ("sound_card" vs "vqmmc_sd1_pvdd") instead of
the node names.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917122701.160720-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=1
prev parent reply other threads:[~2026-09-17 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 12:27 [PATCH] arm64: dts: renesas: r9a09g047e57-smarc: Sort nodes alphabetically Prabhakar
2026-09-17 12:31 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917123123.2A1CB1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox