[PATCH] arm64: dts: renesas: r9a09g047e57-smarc: Sort nodes alphabetically

[PATCH] arm64: dts: renesas: r9a09g047e57-smarc: Sort nodes alphabetically

[Prabhakar]

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Move the sound card node before the vqmmc regulator node to maintain
alphabetical ordering of the nodes under the root node.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../boot/dts/renesas/r9a09g047e57-smarc.dts      | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
index 14f5834082fa..8094599cc8e7 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
+++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
@@ -77,6 +77,14 @@ aliases {
 		mmc1 = &sdhi1;
 	};
 
+	sound_card: sound {
+		compatible = "audio-graph-card";
+
+		label = "snd-rzg3e";
+
+		dais = <&rsnd_port0>;	/* DA7212 */
+	};
+
 	vqmmc_sd1_pvdd: regulator-vqmmc-sd1-pvdd {
 		compatible = "regulator-gpio";
 		regulator-name = "SD1_PVDD";
@@ -86,14 +94,6 @@ vqmmc_sd1_pvdd: regulator-vqmmc-sd1-pvdd {
 		gpios-states = <0>;
 		states = <3300000 0>, <1800000 1>;
 	};
-
-	sound_card: sound {
-		compatible = "audio-graph-card";
-
-		label = "snd-rzg3e";
-
-		dais = <&rsnd_port0>;	/* DA7212 */
-	};
 };
 
 &audio_clkb {
-- 
2.55.0

Re: [PATCH] arm64: dts: renesas: r9a09g047e57-smarc: Sort nodes alphabetically

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: incorrect node sorting breaks alphabetical order
--

commit 6d15dc9289c8e2de0fe2bc1d3748c8961dab0497
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

arm64: dts: renesas: r9a09g047e57-smarc: Sort nodes alphabetically

This commit moves the sound card node before the vqmmc regulator node
in the r9a09g047e57-smarc device tree, with the stated intent of maintaining
alphabetical ordering of the nodes under the root node.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> index 4eed095b683b3..df5ec16d7dbdd 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> @@ -77,6 +77,14 @@ aliases {
>  		mmc1 = &sdhi1;
>  	};
>  
> +	sound_card: sound {
> +		compatible = "audio-graph-card";
> +
> +		label = "snd-rzg3e";
> +
> +		dais = <&rsnd_port0>;	/* DA7212 */
> +	};
> +
>  	vqmmc_sd1_pvdd: regulator-vqmmc-sd1-pvdd {

[Severity: Low]
Does this actually maintain alphabetical ordering?

Standard Device Tree conventions dictate sorting nodes alphabetically by their
node names (the part after the colon), not their labels. Alphabetically by
node name, "regulator-vqmmc-sd1-pvdd" comes before "sound".

It appears this moves the "sound" node before the regulator node by mistake,
perhaps by sorting the labels ("sound_card" vs "vqmmc_sd1_pvdd") instead of
the node names.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917122701.160720-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=1