[PATCH] of: unittest: Fix np reference leak in of_unittest_bus_3cell_ranges()

[PATCH] of: unittest: Fix np reference leak in of_unittest_bus_3cell_ranges()

[Wentao Liang]

of_range_parser_init() can fail when the node lacks a ranges property.
That error path returns without dropping the reference taken by
of_find_node_by_path(). Add the missing of_node_put().

Fixes: 3d5089c4263d ("of/address: Add support for 3 address cell bus")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/of/unittest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 226debdaa5c1..e8257aff17b3 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1350,6 +1350,7 @@ static void __init of_unittest_bus_3cell_ranges(void)
 
 	if (of_range_parser_init(&parser, np)) {
 		pr_err("missing ranges property\n");
+		of_node_put(np);
 		return;
 	}
 
-- 
2.34.1

Re: [PATCH] of: unittest: Fix np reference leak in of_unittest_bus_3cell_ranges()

[Rob Herring]

On Thu, Sep 17, 2026 at 7:46 AM Wentao Liang <vulab@iscas.ac.cn> wrote:
>
> of_range_parser_init() can fail when the node lacks a ranges property.
> That error path returns without dropping the reference taken by
> of_find_node_by_path(). Add the missing of_node_put().
>
> Fixes: 3d5089c4263d ("of/address: Add support for 3 address cell bus")
> Cc: stable@vger.kernel.org

I don't really think we need backports for all of these.

> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/of/unittest.c | 1 +
>  1 file changed, 1 insertion(+)

A general comment for all of these unittest fixes. I think we did a
pass of using the scoped cleanups, but if we could use those it would
be better.

Rob