Re: [PATCH v7 09/12] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: missing vdd-l5-supply for vreg_l5m_2p8 regulator
--

commit 05a1506413b390bab147d74fe91fcbf51d7854fc
Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera

This commit adds the pm8010 camera PMIC regulators to the Lenovo Slim 7x
device tree. It introduces regulators-8 for the camera, defining voltage
levels for the IR and RGB cameras.

> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> index 9eb2dfd99f20d..f4064e09d6231 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> @@ -795,6 +795,57 @@ vreg_l3j_0p8: ldo3 {
[ ... ]
> +	regulators-8 {
> +		compatible = "qcom,pm8010-rpmh-regulators";
> +		qcom,pmic-id = "m";
> +
> +		vdd-l1-l2-supply = <&vreg_s5j_1p2>;
> +		vdd-l3-l4-supply = <&vreg_s4c_1p8>;
> +		vdd-l7-supply = <&vreg_bob1>;

[Severity: Medium]
Is there a missing vdd-l5-supply property for the vreg_l5m_2p8 regulator
here?

The vdd-l5-supply is omitted in regulators-8, but ldo5 is instantiated
further down in this node. Without this supply, the regulator framework
cannot construct the proper power dependency topology. This means the parent
supply will not be implicitly enabled or correctly reference-counted if a
consumer requests vreg_l5m_2p8.

Since there is currently no consumer for vreg_l5m_2p8 introduced in this
series, this issue will only manifest if a future driver attempts to enable
this regulator.

> +
[ ... ]
> +		vreg_l5m_2p8: ldo5 {
> +			regulator-name = "vreg_l5m_2p8";
> +			regulator-min-microvolt = <2800000>;
> +			regulator-max-microvolt = <3072000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-x1e-camss-csi2-phy-dtsi-v7-0-1a63eb35838b@linaro.org?part=9