Re: [PATCH v7 12/12] arm64: dts: qcom: x1e80100-dell-inspiron14-7441: Switch on CAMSS RGB sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] dts: qcom: overvoltage on ov02e10 dvdd-supply due to wrong regulator
--

commit e30274aeaba1c791b56315068d522957cf040acf
Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

arm64: dts: qcom: x1e80100-dell-inspiron14-7441: Switch on CAMSS RGB sensor

Inspiron14 has a ov02e10 sensor on CSIPHY4. Enable the list of dependencies
now.

> diff --git a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
> index 4cda708455d84..5a3bf4eb4ef68 100644
> --- a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
[ ... ]
> @@ -794,6 +796,71 @@ vreg_l3j_0p8: ldo3 {
>  	};
>  };
>  
[ ... ]
> +&cci1_i2c1 {
> +	camera@10 {
> +		compatible = "ovti,ov02e10";
> +		reg = <0x10>;
[ ... ]
> +		orientation = <MEDIA_ORIENTATION_FRONT>;
> +
> +		avdd-supply = <&vreg_l7b_2p8>;
> +		dvdd-supply = <&vreg_l7b_2p8>;

[Severity: Critical]
Could this cause an overvoltage condition on the OV02E10 sensor hardware?

It appears that the 2.8V regulator (vreg_l7b_2p8) is being assigned to the
digital core supply (dvdd-supply), which typically expects 1.2V or 1.8V. When
the sensor driver probes and enables the regulator bulk, unconditionally
applying 2.8V to the digital core might cause permanent hardware damage.

Other similar boards (such as the Lenovo Yoga Slim7x) assign a 1.2V or 1.8V
regulator to dvdd-supply. Is this possibly a copy-paste error from the
avdd-supply line above it?

> +		dovdd-supply = <&vreg_cam_1p8>;
> +
> +		port {
> +			ov02e10_ep: endpoint {
> +				data-lanes = <1 2>;
> +				link-frequencies = /bits/ 64 <360000000>;
> +				remote-endpoint = <&csiphy4_in_ep>;
> +			};
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-x1e-camss-csi2-phy-dtsi-v7-0-1a63eb35838b@linaro.org?part=12