From: sashiko-bot@kernel.org
To: "Junhui Liu" <junhui.liu@pigmoral.tech>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 3/6] dt-bindings: interrupt-controller: thead,c900-aclint-sswi: Add SpacemiT K3
Date: Thu, 17 Sep 2026 16:41:05 +0000 [thread overview]
Message-ID: <20260917164105.DB3EA1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260918-k3-aclint-v3-3-cf4fd4050e14@pigmoral.tech>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing SpacemiT K3 in text description of supported variants
--
commit e153d8cef506aa80d048bbfcecc93b53a351d62b
Author: Junhui Liu <junhui.liu@pigmoral.tech>
dt-bindings: interrupt-controller: thead,c900-aclint-sswi: Add SpacemiT K3
This commit adds support for the SpacemiT K3 ACLINT SSWI. It updates the
compatible strings list to include spacemit,k3-aclint-sswi.
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/thead,c900-aclint-sswi.yaml b/Documentation/devicetree/bindings/interrupt-controller/thead,c900-aclint-sswi.yaml
> index d02c6886283af..0b34ed5b4639d 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/thead,c900-aclint-sswi.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/thead,c900-aclint-sswi.yaml
> @@ -24,12 +24,13 @@ description:
[Severity: Low]
Does the text description of supported variants need to be updated to match
the new compatible string?
Looking at the full description block in
Documentation/devicetree/bindings/interrupt-controller/thead,c900-aclint-sswi.yaml:
Following variants of the SSWI ACLINT supported, using dedicated
compatible string
- THEAD C900
- MIPS P8700
Should the SpacemiT K3 variant be added to this list so the documentation
stays in sync with the new schema properties?
> properties:
> compatible:
> oneOf:
> + - enum:
> + - mips,p8700-aclint-sswi
> + - spacemit,k3-aclint-sswi
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-k3-aclint-v3-0-cf4fd4050e14@pigmoral.tech?part=3
next prev parent reply other threads:[~2026-09-17 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 16:29 [PATCH v3 0/6] spacemit: k3: Replace bad CLINT node with ACLINT nodes Junhui Liu
2026-09-17 16:29 ` [PATCH v3 1/6] dt-bindings: timer: thead,c900-aclint-mtimer: Add SpacemiT K3 Junhui Liu
2026-09-17 16:29 ` [PATCH v3 2/6] dt-bindings: interrupt-controller: thead,c900-aclint-mswi: " Junhui Liu
2026-09-17 16:29 ` [PATCH v3 3/6] dt-bindings: interrupt-controller: thead,c900-aclint-sswi: " Junhui Liu
2026-09-17 16:41 ` sashiko-bot [this message]
2026-09-17 16:29 ` [PATCH v3 4/6] dt-bindings: timer: sifive,clint: Remove spacemit,k3-clint Junhui Liu
2026-09-28 18:02 ` Rob Herring (Arm)
2026-09-17 16:29 ` [PATCH v3 5/6] irqchip/aclint-sswi: Add support for SpacemiT K3 Junhui Liu
2026-09-19 0:06 ` Yixun Lan
2026-10-02 11:25 ` Yixun Lan
2026-09-17 16:29 ` [PATCH v3 6/6] riscv: dts: spacemit: k3: Replace incorrect CLINT node with ACLINT nodes Junhui Liu
2026-09-18 23:52 ` [PATCH v3 0/6] spacemit: k3: Replace bad " Yixun Lan
2026-10-02 11:19 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917164105.DB3EA1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=junhui.liu@pigmoral.tech \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox